[21670] Fix failing tests in Router 2.x #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #508 +/- ##
======================================
Coverage ? 30.41%
======================================
Files ? 16
Lines ? 559
Branches ? 297
======================================
Hits ? 170
Misses ? 202
Partials ? 187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cferreiragonz
force-pushed
the
fix_destructor_tests
branch
from
70ffbb4 to
7f2a959
Compare
cferreiragonz
requested review from
richiprosima
and removed request for
richiprosima
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
cferreiragonz
force-pushed
the
fix_destructor_tests
branch
from
501a6d1 to
e10eb05
Compare
Contributor
Author
|
This PR only modifies tests of |
cferreiragonz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the order in the destructor of
TestSubscriber, which avoids a case in which running severaltest_WAN_communicationin a row resulted in no communication.It also adds whitelist for Discovery Server routers tests. This is needed because locators transformation is never accomplished with Discovery Servers in Fast DDS 2.x due to fixed GUIDs. This forces extra channels creations for TCP, but most important it does not rely on localhost for communication, which results in errors for TCPv6. By adding a whitelist this problem is avoided.
The fix to this issue was solved in Fast DDS 3.x by adding the
machine_idfield and non-fixed GUIDs for Discovery Servers.