-
Notifications
You must be signed in to change notification settings - Fork 23
[21670] Use 'Debug' binaries for TSAN tests #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
==========================================
- Coverage 31.14% 30.24% -0.90%
==========================================
Files 16 16
Lines 594 562 -32
Branches 321 298 -23
==========================================
- Hits 185 170 -15
+ Misses 213 205 -8
+ Partials 196 187 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
EugenioCollado
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
91bc834 to
e6d1c38
Compare
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
|
TSAN tests now correctly report the failing test, which will be solved in eProsima/DDS-Pipe#145. Docker tests will be solved in #513. |
EugenioCollado
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR modifies the github action definition of TSAN tests to use the
Debugbinaries instead of theReleaseones and also rely on the tsan binary created for both DDS Pipe and Fast DDS.