Skip to content

Conversation

@cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented May 27, 2025

This PR modifies the github action definition of TSAN tests to use the Debug binaries instead of the Release ones and also rely on the tsan binary created for both DDS Pipe and Fast DDS.

@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.24%. Comparing base (63cb664) to head (137b2b2).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
- Coverage   31.14%   30.24%   -0.90%     
==========================================
  Files          16       16              
  Lines         594      562      -32     
  Branches      321      298      -23     
==========================================
- Hits          185      170      -15     
+ Misses        213      205       -8     
+ Partials      196      187       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
EugenioCollado
EugenioCollado previously approved these changes Jun 13, 2025
Copy link

@EugenioCollado EugenioCollado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz
Copy link
Contributor Author

TSAN tests now correctly report the failing test, which will be solved in eProsima/DDS-Pipe#145. Docker tests will be solved in #513.

Copy link

@EugenioCollado EugenioCollado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanlofer-eprosima juanlofer-eprosima merged commit 8abc3d8 into main Jun 17, 2025
29 of 33 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the use_debug_for_tsan branch June 17, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants