Skip to content

Conversation

@cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Jun 13, 2025

This PR selects the Vulcanexus base image used for testing according the Fast DDS version used.

It also removes the temporary workaround introduced in #510 to fix ROS 2 apt keys.

It must be merged after rebuilding all docker images.

@codecov
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.24%. Comparing base (8abc3d8) to head (5ad4819).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
- Coverage   31.14%   30.24%   -0.90%     
==========================================
  Files          16       16              
  Lines         594      562      -32     
  Branches      321      298      -23     
==========================================
- Hits          185      170      -15     
+ Misses        213      205       -8     
+ Partials      196      187       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cferreiragonz
Copy link
Contributor Author

Arguments were checked here and here.

@cferreiragonz cferreiragonz changed the title Use Vulcanexus-humble image with Fast DDS 2.x Use different Vulcanexus images for each Fast DDS version Jun 17, 2025
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz
Copy link
Contributor Author

New CI tests:

Copy link

@EugenioCollado EugenioCollado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanlofer-eprosima juanlofer-eprosima merged commit a88d9cf into main Jun 20, 2025
52 of 101 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the fix_system_ci branch June 20, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants