Skip to content

Conversation

@emiliocuestaf
Copy link
Contributor

Adds a blackbox test that checks that:

  • dds-pipe sets the original writer when the original writer is unknown
  • dds-pipe keeps the original writer when it is known

This PR depends on eProsima/DDS-Pipe#163 and must be merged after it.

@cferreiragonz cferreiragonz changed the title [23573] Refs #23573, add blackbox tests for original writer info in ddspipe [23573] Add blackbox tests for original writer info in ddspipe Aug 27, 2025
Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can swap case 2 and case 3. In this way the expected value on the subscriber side will change between the three tested cases. Right now, case 1 and case 2 will generate the same value and it might occur that the value is not updated but the test does not report it.

cferreiragonz
cferreiragonz previously approved these changes Aug 28, 2025
Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.24%. Comparing base (4f70d05) to head (64353c9).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
- Coverage   31.14%   30.24%   -0.90%     
==========================================
  Files          16       16              
  Lines         594      562      -32     
  Branches      321      298      -23     
==========================================
- Hits          185      170      -15     
+ Misses        213      205       -8     
+ Partials      196      187       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emiliocuestaf emiliocuestaf merged commit f5bca80 into main Sep 2, 2025
33 of 35 checks passed
@emiliocuestaf emiliocuestaf deleted the feature/original-writer-forwarding-tests branch September 2, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants