-
Notifications
You must be signed in to change notification settings - Fork 23
[23573] Add blackbox tests for original writer info in ddspipe #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Emilio Cuesta <[email protected]>
cferreiragonz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can swap case 2 and case 3. In this way the expected value on the subscriber side will change between the three tested cases. Right now, case 1 and case 2 will generate the same value and it might occur that the value is not updated but the test does not report it.
ddsrouter_core/test/blackbox/ddsrouter_core/dds/local/DDSTestLocal.cpp
Outdated
Show resolved
Hide resolved
ddsrouter_core/test/blackbox/ddsrouter_core/dds/types/test_participants.hpp
Outdated
Show resolved
Hide resolved
ddsrouter_core/test/blackbox/ddsrouter_core/dds/local/DDSTestLocal.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
cferreiragonz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Signed-off-by: Emilio Cuesta <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
==========================================
- Coverage 31.14% 30.24% -0.90%
==========================================
Files 16 16
Lines 594 562 -32
Branches 321 298 -23
==========================================
- Hits 185 170 -15
+ Misses 213 205 -8
+ Partials 196 187 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Emilio Cuesta <[email protected]>
cferreiragonz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds a blackbox test that checks that:
This PR depends on eProsima/DDS-Pipe#163 and must be merged after it.