Skip to content

[23821] First align then save last_data_size_ #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MiguelCompany merged 2 commits into from
Oct 15, 2025
Merged

[23821] First align then save last_data_size_ #282

MiguelCompany merged 2 commits into from
Oct 15, 2025

Conversation

@MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Oct 14, 2025 •
edited by richiware
Loading

Description

This fixes #211 by first calling make_alignment, then setting last_data_size_.

@Mergifyio backport 2.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

@MiguelCompany
Refs #23821. First align then save last_data_size_.
694eadc 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v2.3.3 milestone Oct 14, 2025
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima October 14, 2025 10:49
@MiguelCompany MiguelCompany mentioned this pull request Oct 14, 2025
Closed
@MiguelCompany
Refs #23821. Uncrustify.
4fba644 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany merged commit 276d7f5 into master Oct 15, 2025
12 checks passed
@MiguelCompany MiguelCompany deleted the feature/23821 branch October 15, 2025 07:25
@MiguelCompany
Copy link
Member Author

MiguelCompany commented Oct 15, 2025

@Mergifyio backport 2.2.x

@mergify
Copy link

mergify bot commented Oct 15, 2025 •
edited
Loading

backport 2.2.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Oct 15, 2025
@MiguelCompany @mergify
First align then save last_data_size_ (#282)
15dd8c9 
* Refs #23821. First align then save `last_data_size_`.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23821. Uncrustify.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 276d7f5)
@mergify mergify bot mentioned this pull request Oct 15, 2025
Merged
10 tasks
MiguelCompany added a commit that referenced this pull request Oct 15, 2025
@mergify @MiguelCompany
First align then save last_data_size_ (#282) (#283)
7f56d28 
* Refs #23821. First align then save `last_data_size_`.



* Refs #23821. Uncrustify.



---------


(cherry picked from commit 276d7f5)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richiware richiware richiware approved these changes

Assignees

No one assigned

Labels

ci-pending

Projects

None yet

Milestone

v2.3.3

Development

Successfully merging this pull request may close these issues.

Optimization of the alignment calculation using the Cdr::alignment() method does not work

3 participants

@MiguelCompany @richiware