-
Notifications
You must be signed in to change notification settings - Fork 123
[23848] XCDRv1: support extra bytes in optional types #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
MiguelCompany
requested changes
Oct 24, 2025
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
MiguelCompany
approved these changes
Oct 24, 2025
Member
|
@Mergifyio backport 2.2.x |
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 24, 2025
* Refs #23838. Regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23838. Fix Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23838. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 486ce90)
12 tasks
MiguelCompany
pushed a commit
that referenced
this pull request
Oct 24, 2025
* Refs #23838. Regression test * Refs #23838. Fix * Refs #23838. Apply suggestions --------- (cherry picked from commit 486ce90) Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Ricardo González <ricardo@richiware.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some XCDRv1 implementations add extra bytes, usually alignment bytes, at the end of the serialized base type of an optional type. And this extra bytes are took into account in the parameter's length which describes the optional. Currently fastcdr doesn't support this. The parameter's length of a optional has to have the exact length of the serialized base type.
This PR introduces this flexibility to support other XCDRv1 implementations.
@Mergifyio backport 2.2.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist