[22648] Unacknowledged sample removed in KeepAll mode (backport #5618)

[mergify]

on_unacknowledged_sample_removed callback is called when writer with keep all history is used, when the history was full but before max_blocking_time a sample was acknowledged, as is_acked was checked before the waiting time, and is not re-checked. This should not happen, as keep all should never drop an unacknowledged sample.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Contributor Checklist

• Commit messages follow the project guidelines.

• The code follows the style guidelines of this project.

• Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

• N/A Any new/modified methods have been properly documented using Doxygen.

• N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

• Changes are backport compatible: they do NOT break ABI nor change library core behavior.

• Changes are API compatible.

• N/A New feature has been added to the versions.md file (if applicable).

• N/A New feature has been documented/Current behavior is correctly described in the documentation.

• Applicable backports have been included in the description.

Reviewer Checklist

• The PR has a milestone assigned.
• The title and description correctly express the PR's purpose.
• Check contributor checklist is correct.
• If this is a critical bug fix, backports to the critical-only supported branches have been requested.
• Check CI results: changes do not issue any warning.
• Check CI results: failing tests are unrelated with the changes.

---

This is an automatic backport of pull request #5618 done by [Mergify](https://mergify.com).

[mergify]

Cherry-pick of 68f97fe has failed:

On branch mergify/bp/3.0.x/pr-5618
Your branch is up to date with 'origin/3.0.x'.

You are currently cherry-picking commit 68f97fe2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/cpp/fastdds/publisher/DataWriterHistory.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/blackbox/common/DDSBlackboxTestsListeners.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[Javgilavi]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[Javgilavi]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[Javgilavi]

LGTM