Skip to content

[22756] Fix error handling logic in try_setting_buffer_size (backport #5631)#5641

Merged
MiguelCompany merged 1 commit into3.1.xfrom
mergify/bp/3.1.x/pr-5631
Feb 11, 2025
Merged

[22756] Fix error handling logic in try_setting_buffer_size (backport #5631)#5641
MiguelCompany merged 1 commit into3.1.xfrom
mergify/bp/3.1.x/pr-5631

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Feb 10, 2025

Description

This should fix #4684 by applying the last suggested changes

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • NO: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A: Any new/modified methods have been properly documented using Doxygen.

  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A: New feature has been added to the versions.md file (if applicable).

  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5631 done by [Mergify](https://mergify.com).

* Refs #22208. Fix error handling logic in `try_setting_buffer_size`.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #22756. Apply suggestion.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 7259840)
@MiguelCompany MiguelCompany self-requested a review February 10, 2025 18:51
@github-actions github-actions bot added the ci-pending PR which CI is running label Feb 10, 2025
@MiguelCompany MiguelCompany merged commit 23c24c4 into 3.1.x Feb 11, 2025
15 of 16 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/3.1.x/pr-5631 branch February 11, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant