[22710] Filter interested readers on PDP writer (backport #5604) by EugenioCollado · Pull Request #5672 · eProsima/Fast-DDS

EugenioCollado · 2025-02-28T12:48:57Z

Description

Manual backport ABI compatible from: #5604

This fixes a high CPU and network usage situation with PDP simple discovery when a new participant is created in a network where there is a high number of existing participants.

@Mergifyio backport 2.10x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
NA Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
NA New feature has been added to the versions.md file (if applicable).
NA New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

include/fastdds/rtps/writer/StatelessWriter.h

MiguelCompany · 2025-03-05T10:18:55Z

@richiprosima Please check style

MiguelCompany

Please fix uncrustify

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

MiguelCompany

LGTM

MiguelCompany · 2025-03-17T09:01:29Z

@Mergifyio backport 2.10.x

mergify · 2025-03-17T09:02:04Z

backport 2.10.x

✅ Backports have been created

Details

#5709 [22710] Filter interested readers on PDP writer (backport #5604) (backport #5672) has been created for branch 2.10.x but encountered conflicts

* Refs #22506. Regression test. Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Refs #22506. Filter interested readers on PDP writer Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Fix IncompatibleQosGetters Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Fix PubSubParticipant rtps deprecated Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> --------- Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> (cherry picked from commit b56b56a) # Conflicts: # src/cpp/rtps/participant/RTPSParticipantImpl.cpp # test/blackbox/api/fastrtps_deprecated/PubSubParticipant.hpp # test/blackbox/common/DDSBlackboxTestsMonitorService.cpp # test/unittest/statistics/dds/CMakeLists.txt

* Refs #22506. Regression test. Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Refs #22506. Filter interested readers on PDP writer Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Fix IncompatibleQosGetters Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Fix PubSubParticipant rtps deprecated Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> --------- Manual conflicts resolution from commit b56b56a Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Refs #22506. Regression test. * Refs #22506. Filter interested readers on PDP writer * Fix IncompatibleQosGetters * Fix PubSubParticipant rtps deprecated --------- Manual conflicts resolution from commit b56b56a Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> Co-authored-by: Eugenio Collado <eugeniocollado@eprosima.com>

EugenioCollado added this to the v2.14.5 milestone Feb 28, 2025

EugenioCollado requested a review from MiguelCompany February 28, 2025 12:49

EugenioCollado added the ci-pending PR which CI is running label Feb 28, 2025

EugenioCollado changed the base branch from master to 2.14.x February 28, 2025 12:49

EugenioCollado requested a review from richiprosima February 28, 2025 12:51

MiguelCompany approved these changes Mar 5, 2025

View reviewed changes

include/fastdds/rtps/writer/StatelessWriter.h Show resolved Hide resolved

MiguelCompany requested review from richiprosima and removed request for richiprosima March 5, 2025 10:13

MiguelCompany requested changes Mar 5, 2025

View reviewed changes

MiguelCompany changed the title ~~[22604] Filter interested readers on PDP writer (backport #5604)~~ [22710] Filter interested readers on PDP writer (backport #5604) Mar 5, 2025

EugenioCollado added 2 commits March 13, 2025 09:37

Refs #22506. Regression test.

c981d1c

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

Refs #22506. Filter interested readers on PDP writer

69e6f33

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

EugenioCollado added ci-pending PR which CI is running and removed ci-pending PR which CI is running labels Mar 13, 2025

EugenioCollado requested a review from richiprosima March 13, 2025 09:06

EugenioCollado force-pushed the manual-bp/2.14.x/pr-5604 branch from 3d3b64c to c740c5d Compare March 13, 2025 09:37

EugenioCollado removed the ci-pending PR which CI is running label Mar 13, 2025

EugenioCollado removed the request for review from richiprosima March 13, 2025 09:38

EugenioCollado added the ci-pending PR which CI is running label Mar 13, 2025

EugenioCollado requested a review from richiprosima March 13, 2025 09:38

Fix IncompatibleQosGetters

3a48940

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

EugenioCollado force-pushed the manual-bp/2.14.x/pr-5604 branch 3 times, most recently from 1eb5249 to d8dca0f Compare March 13, 2025 14:54

EugenioCollado added ci-pending PR which CI is running and removed ci-pending PR which CI is running labels Mar 13, 2025

EugenioCollado requested review from richiprosima and removed request for richiprosima March 13, 2025 14:57

EugenioCollado force-pushed the manual-bp/2.14.x/pr-5604 branch from d8dca0f to 967b37b Compare March 13, 2025 15:54

EugenioCollado removed the ci-pending PR which CI is running label Mar 13, 2025

EugenioCollado removed the request for review from richiprosima March 13, 2025 15:56

EugenioCollado added the ci-pending PR which CI is running label Mar 13, 2025

EugenioCollado requested a review from richiprosima March 13, 2025 15:56

EugenioCollado force-pushed the manual-bp/2.14.x/pr-5604 branch from 967b37b to 825b55b Compare March 14, 2025 07:05

EugenioCollado removed the ci-pending PR which CI is running label Mar 14, 2025

EugenioCollado removed the request for review from richiprosima March 14, 2025 07:12

EugenioCollado added the ci-pending PR which CI is running label Mar 14, 2025

EugenioCollado requested a review from richiprosima March 14, 2025 07:12

EugenioCollado force-pushed the manual-bp/2.14.x/pr-5604 branch from 825b55b to adc3c05 Compare March 14, 2025 08:35

Fix PubSubParticipant rtps deprecated

607006d

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

EugenioCollado force-pushed the manual-bp/2.14.x/pr-5604 branch from adc3c05 to 607006d Compare March 14, 2025 08:38

EugenioCollado removed the ci-pending PR which CI is running label Mar 14, 2025

EugenioCollado requested review from richiprosima and removed request for richiprosima March 14, 2025 08:42

EugenioCollado added the ci-pending PR which CI is running label Mar 14, 2025

MiguelCompany approved these changes Mar 17, 2025

View reviewed changes

MiguelCompany merged commit b56b56a into 2.14.x Mar 17, 2025
17 of 18 checks passed

MiguelCompany deleted the manual-bp/2.14.x/pr-5604 branch March 17, 2025 09:01

eProsima deleted a comment from mergify bot Mar 17, 2025

mergify bot mentioned this pull request Mar 17, 2025

[22710] Filter interested readers on PDP writer (backport #5604) (backport #5672) #5709

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[22710] Filter interested readers on PDP writer (backport #5604)#5672

[22710] Filter interested readers on PDP writer (backport #5604)#5672
MiguelCompany merged 4 commits into2.14.xfrom
manual-bp/2.14.x/pr-5604

EugenioCollado commented Feb 28, 2025 •

edited by MiguelCompany

Loading

Uh oh!

Uh oh!

MiguelCompany commented Mar 5, 2025

Uh oh!

MiguelCompany left a comment

Uh oh!

MiguelCompany left a comment

Uh oh!

Uh oh!

MiguelCompany commented Mar 17, 2025 •

edited

Loading

Uh oh!

mergify bot commented Mar 17, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

EugenioCollado commented Feb 28, 2025 • edited by MiguelCompany Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

Uh oh!

MiguelCompany commented Mar 5, 2025

Uh oh!

MiguelCompany left a comment

Choose a reason for hiding this comment

Uh oh!

MiguelCompany left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MiguelCompany commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify bot commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

EugenioCollado commented Feb 28, 2025 •

edited by MiguelCompany

Loading

MiguelCompany commented Mar 17, 2025 •

edited

Loading

mergify bot commented Mar 17, 2025 •

edited

Loading