Skip to content

[23459] Fix/socket buffer size handling#5926

Merged
MiguelCompany merged 5 commits intomasterfrom
fix/socket_buffer_size_handling
Jul 14, 2025
Merged

[23459] Fix/socket buffer size handling#5926
MiguelCompany merged 5 commits intomasterfrom
fix/socket_buffer_size_handling

Conversation

@EugenioCollado
Copy link
Contributor

@EugenioCollado EugenioCollado commented Jul 9, 2025

Description

This task aims to fix:

  • test_UDPv4Transport does not actually set the socket buffer size

  • try_setting_buffer_size final attempt sets an upper limit for the buffer size that is not implemented in the main loop

This PR is a frontport of the proper changes from #5921

@Mergifyio backport 3.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
@EugenioCollado EugenioCollado added the ci-pending PR which CI is running label Jul 9, 2025
@EugenioCollado EugenioCollado added this to the v3.3.1 milestone Jul 10, 2025
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
@EugenioCollado EugenioCollado requested review from richiprosima and removed request for richiprosima July 10, 2025 10:07
@EugenioCollado EugenioCollado added the needs-review PR that is ready to be reviewed label Jul 10, 2025
@MiguelCompany MiguelCompany removed the needs-review PR that is ready to be reviewed label Jul 10, 2025
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
@EugenioCollado EugenioCollado requested review from richiprosima and removed request for richiprosima July 10, 2025 12:41
@EugenioCollado
Copy link
Contributor Author

@MiguelCompany failing test example_tests.custom_payload_pool seems unrelated

@EugenioCollado EugenioCollado added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jul 11, 2025
@MiguelCompany MiguelCompany merged commit 8e9292e into master Jul 14, 2025
34 of 37 checks passed
@MiguelCompany MiguelCompany deleted the fix/socket_buffer_size_handling branch July 14, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants