Skip to content

[23515] Update 3.3.x to be a supported branch#5941

Merged
rsanchez15 merged 3 commits into3.3.xfrom
branchout/3.4.x-3.3.x
Jul 21, 2025
Merged

[23515] Update 3.3.x to be a supported branch#5941
rsanchez15 merged 3 commits into3.3.xfrom
branchout/3.4.x-3.3.x

Conversation

@emiliocuestaf
Copy link
Contributor

@emiliocuestaf emiliocuestaf commented Jul 17, 2025

Description

This PR updates 3.3.x sources to be considered a supported branch:

  • Fix versions in fastdds.repos to the 3.3.x corresponding versions
  • Remove mirror, nightly and weekly workflows
  • Update master references to 3.3.x
  • Update README references to nightly workflows

This PR depends on and must be merged after:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • [N/A] The code follows the style guidelines of this project.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [N/A] Any new/modified methods have been properly documented using Doxygen.
  • [N/A] Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • [N/A] Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • [N/A] Changes are API compatible.
  • [N/A] New feature has been added to the versions.md file (if applicable).
  • [N/A] New feature has been documented/Current behavior is correctly described in the documentation.
  • [N/A] Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@emiliocuestaf emiliocuestaf requested a review from Mario-DL July 17, 2025 13:54
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 17, 2025
Copy link
Contributor

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments below, please change the target branch to be 3.3.x instead of master

@Mario-DL Mario-DL added no-test Skip CI tests if PR marked with this label and removed no-test Skip CI tests if PR marked with this label labels Jul 18, 2025
@Mario-DL
Copy link
Contributor

Mario-DL commented Jul 18, 2025

Also, please, update the description the 3.1.x references to 3.3.x

@rsanchez15 rsanchez15 changed the base branch from master to 3.3.x July 18, 2025 10:36
@Mario-DL Mario-DL added the no-test Skip CI tests if PR marked with this label label Jul 18, 2025
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL requested review from Mario-DL and removed request for Mario-DL July 18, 2025 11:09
@Mario-DL Mario-DL removed the no-test Skip CI tests if PR marked with this label label Jul 18, 2025
@Mario-DL Mario-DL requested review from Mario-DL and removed request for Mario-DL July 18, 2025 11:09
Copy link
Contributor

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany added this to the v3.3.1 milestone Jul 18, 2025
@rsanchez15 rsanchez15 merged commit aa3dd44 into 3.3.x Jul 21, 2025
28 of 40 checks passed
@rsanchez15 rsanchez15 deleted the branchout/3.4.x-3.3.x branch July 21, 2025 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants