[23603] Avoid sending duplicated ACKs in DataSharing by cferreiragonz · Pull Request #5986 · eProsima/Fast-DDS

cferreiragonz · 2025-08-26T11:04:51Z

Description

This PR improves DataSharing efficiency by removing an extra ACK that was being sent when StatefulReader::end_sample_access_nts and DataReaderHistory::remove_change_sub were being called consecutively.

@Mergifyio backport 3.3.x 3.2.x 2.14.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

mergify · 2025-08-27T13:36:13Z

🧪 CI Insights

Here's what we observed from your CI run for 241a446.

❌ Failed Jobs

Pipeline	Job	Health on `master`	Retries	🔍 CI Insights	📄 Logs
`Fast DDS MacOS CI`	`mac-ci / reusable-mac-ci (RelWithDebInfo)`		`0`	View	View

MiguelCompany · 2025-09-03T09:58:48Z

@Mergifyio backport 3.3.x 3.2.x 2.14.x

mergify · 2025-09-03T09:58:57Z

backport 3.3.x 3.2.x 2.14.x

✅ Backports have been created

Details

#6002 [23603] Avoid sending duplicated ACKs in DataSharing (backport #5986) has been created for branch 3.3.x
#6003 [23603] Avoid sending duplicated ACKs in DataSharing (backport #5986) has been created for branch 3.2.x
#6004 [23603] Avoid sending duplicated ACKs in DataSharing (backport #5986) has been created for branch 2.14.x but encountered conflicts

* Refs #23603: Avoid duplicate ACK in datasharing Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23603: Doxygen Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23603: Mock method Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 8421fb0)

* Refs #23603: Avoid duplicate ACK in datasharing Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23603: Doxygen Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23603: Mock method Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 8421fb0) # Conflicts: # include/fastdds/rtps/reader/StatefulReader.h # include/fastdds/rtps/reader/StatelessReader.h # src/cpp/fastdds/subscriber/DataReaderImpl/ReadTakeCommand.hpp # src/cpp/rtps/reader/BaseReader.hpp # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/mock/rtps/RTPSReader/rtps/reader/BaseReader.hpp

* Refs #23603: Avoid duplicate ACK in datasharing Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23603: Doxygen Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23603: Mock method Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #23603: Avoid duplicate ACK in datasharing Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23603: Doxygen Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23603: Mock method Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 8421fb0)

* Refs #23603: Avoid duplicate ACK in datasharing * Refs #23603: Doxygen * Refs #23603: Mock method --------- (cherry picked from commit 8421fb0) Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>

* Refs #23603: Avoid duplicate ACK in datasharing Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23603: Doxygen Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23603: Mock method Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 8421fb0)

* Avoid sending duplicated ACKs in DataSharing (#5986) * Refs #23603: Avoid duplicate ACK in datasharing Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23603: Doxygen Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23603: Mock method Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 8421fb0) * Uncrustify Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>

* Refs #23603: Avoid duplicate ACK in datasharing Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23603: Doxygen Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23603: Mock method Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 8421fb0) # Conflicts: # include/fastdds/rtps/reader/StatefulReader.h # include/fastdds/rtps/reader/StatelessReader.h # src/cpp/fastdds/subscriber/DataReaderImpl/ReadTakeCommand.hpp # src/cpp/rtps/reader/BaseReader.hpp # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/mock/rtps/RTPSReader/rtps/reader/BaseReader.hpp

* Avoid sending duplicated ACKs in DataSharing (#5986) * Refs #23603: Avoid duplicate ACK in datasharing Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23603: Doxygen Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23603: Mock method Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 8421fb0) # Conflicts: # include/fastdds/rtps/reader/StatefulReader.h # include/fastdds/rtps/reader/StatelessReader.h # src/cpp/fastdds/subscriber/DataReaderImpl/ReadTakeCommand.hpp # src/cpp/rtps/reader/BaseReader.hpp # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/mock/rtps/RTPSReader/rtps/reader/BaseReader.hpp * Fix backport issues Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Update include/fastdds/rtps/reader/StatelessReader.h Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Update src/cpp/rtps/reader/StatelessReader.cpp Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Update include/fastdds/rtps/reader/StatefulReader.h Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Update include/fastdds/rtps/reader/StatefulReader.h Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Update include/fastdds/rtps/reader/StatelessReader.h Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: Emilio Cuesta <emiliocuesta@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

cferreiragonz added 2 commits August 26, 2025 12:42

Refs #23603: Avoid duplicate ACK in datasharing

97e3e14

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #23603: Doxygen

0b656e8

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

cferreiragonz added this to the v3.4.0 milestone Aug 26, 2025

cferreiragonz requested a review from richiprosima August 26, 2025 11:05

github-actions bot added the ci-pending PR which CI is running label Aug 26, 2025

cferreiragonz removed the request for review from richiprosima August 26, 2025 11:05

Refs #23603: Mock method

241a446

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

cferreiragonz requested review from richiprosima and removed request for richiprosima August 27, 2025 05:50

cferreiragonz marked this pull request as ready for review August 29, 2025 09:34

MiguelCompany approved these changes Sep 2, 2025

View reviewed changes

MiguelCompany merged commit 8421fb0 into master Sep 3, 2025
43 of 48 checks passed

MiguelCompany deleted the fix_ack_data_sharing branch September 3, 2025 09:58

This was referenced Sep 3, 2025

[23603] Avoid sending duplicated ACKs in DataSharing (backport #5986) #6002

Merged

[23603] Avoid sending duplicated ACKs in DataSharing (backport #5986) #6003

Merged

[23603] Avoid sending duplicated ACKs in DataSharing (backport #5986) #6004

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[23603] Avoid sending duplicated ACKs in DataSharing#5986

[23603] Avoid sending duplicated ACKs in DataSharing#5986
MiguelCompany merged 3 commits intomasterfrom
fix_ack_data_sharing

cferreiragonz commented Aug 26, 2025 •

edited by MiguelCompany

Loading

Uh oh!

mergify bot commented Aug 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

MiguelCompany commented Sep 3, 2025

Uh oh!

mergify bot commented Sep 3, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

cferreiragonz commented Aug 26, 2025 • edited by MiguelCompany Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

mergify bot commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 CI Insights

❌ Failed Jobs

Uh oh!

Uh oh!

MiguelCompany commented Sep 3, 2025

Uh oh!

mergify bot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cferreiragonz commented Aug 26, 2025 •

edited by MiguelCompany

Loading

mergify bot commented Aug 27, 2025 •

edited

Loading

mergify bot commented Sep 3, 2025 •

edited

Loading