Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 2, 2025

Description

Some errors have been reported when the RPC example application is stopped using multiple SIGINT signals, due to signal handler implicitly calls async-signal-unsafe functions. This PR solves the problem.

@Mergifyio backport 3.3.x 3.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5974 done by [Mergify](https://mergify.com).

* Refs #23569: Improve signal handling

Signed-off-by: Carlosespicur <[email protected]>

* Refs #23569: Fix signal handling

Signed-off-by: Carlosespicur <[email protected]>

* Refs #23569: Review - Apply suggestions

Signed-off-by: Carlosespicur <[email protected]>

---------

Signed-off-by: Carlosespicur <[email protected]>
(cherry picked from commit 0a9b827)
@MiguelCompany MiguelCompany added this to the v3.2.3 milestone Sep 2, 2025
@MiguelCompany MiguelCompany self-requested a review September 2, 2025 07:38
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 2, 2025
Copy link
Contributor Author

mergify bot commented Sep 2, 2025

🧪 CI Insights

Here's what we observed from your CI run for 46ababf.

❌ Failed Jobs

Pipeline Job Health on 3.2.x Retries 🔍 CI Insights 📄 Logs
Fast DDS Sanitizers CI sanitizers-ci / asan_fastdds_test Unknown 0 View View

@MiguelCompany MiguelCompany deleted the mergify/bp/3.2.x/pr-5974 branch October 1, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants