[23603] Avoid sending duplicated ACKs in DataSharing (backport #5986) #6002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=80&v=4){kind=small}
12 tasks
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
MiguelCompany
force-pushed
the
mergify/bp/3.3.x/pr-5986
branch
from
3907e90 to
e662845
Compare
MiguelCompany
previously approved these changes
Oct 7, 2025
|
@Mergifyio rebase |
* Refs #23603: Avoid duplicate ACK in datasharing Signed-off-by: cferreiragonz <[email protected]> * Refs #23603: Doxygen Signed-off-by: cferreiragonz <[email protected]> * Refs #23603: Mock method Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit 8421fb0)
Signed-off-by: Carlos Ferreira González <[email protected]>
✅ Branch has been successfully rebased |
cferreiragonz
force-pushed
the
mergify/bp/3.3.x/pr-5986
branch
from
d627084 to
168330f
Compare
cferreiragonz
requested review from
richiprosima
and removed request for
richiprosima
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves DataSharing efficiency by removing an extra ACK that was being sent when
StatefulReader::end_sample_access_ntsandDataReaderHistory::remove_change_subwere being called consecutively.@Mergifyio backport 3.3.x 3.2.x 2.14.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5986 done by [Mergify](https://mergify.com).