[23624] Allow empty partition list to match against "*" (backport #5989)#6006
Merged
MiguelCompany merged 1 commit into3.3.xfrom Nov 12, 2025
Merged
[23624] Allow empty partition list to match against "*" (backport #5989)#6006MiguelCompany merged 1 commit into3.3.xfrom
"*" (backport #5989)#6006MiguelCompany merged 1 commit into3.3.xfrom
Conversation
11 tasks
Contributor
Author
🧪 CI InsightsHere's what we observed from your CI run for cd895bf. ❌ Job Failures
|
Contributor
|
@Mergifyio rebase |
Contributor
Author
✅ Branch has been successfully rebased |
cferreiragonz
force-pushed
the
mergify/bp/3.3.x/pr-5989
branch
from
25c9336 to
d0db55e
Compare
cferreiragonz
approved these changes
Nov 6, 2025
Contributor
|
@Mergifyio rebase |
* Refs #23623. Always use StringMatching. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23623. Refactor StringMatching. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23623. Regression unit test.. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23623. Fix StringMatching on Windows. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23624. Avoid unnecessary conditionals. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 27ce90d)
Contributor
Author
✅ Branch has been successfully rebased |
cferreiragonz
force-pushed
the
mergify/bp/3.3.x/pr-5989
branch
from
d0db55e to
cd895bf
Compare
cferreiragonz
requested review from
richiprosima
and removed request for
richiprosima
cferreiragonz
added
ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A partition with value
"*"should match with a partition with value"".An empty partition list should be treated as a list with a single partition with value
"".This should also match with a partition with value
"*".This PR refactors the matching of partitions to always use the
StringMatchingclass, and makes the behavior of that class with respect to empty strings consistent between platforms.@Mergifyio backport 3.3.x 3.2.x 2.14.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the
versions.mdfile (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5989 done by [Mergify](https://mergify.com).