Skip to content

Release change while authentication fails (backport #5935)#6020

Merged
juanlofer-eprosima merged 1 commit into3.3.xfrom
mergify/bp/3.3.x/pr-5935
Nov 13, 2025
Merged

Release change while authentication fails (backport #5935)#6020
juanlofer-eprosima merged 1 commit into3.3.xfrom
mergify/bp/3.3.x/pr-5935

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Sep 10, 2025

Description

Address #5934

particiapant_stateless_message_writer_history should be properly freed when authentication fails.

@Mergifyio backport 3.3.x 3.2.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • Any new/modified methods have been properly documented using Doxygen.

  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5935 done by [Mergify](https://mergify.com).

@mergify mergify bot mentioned this pull request Sep 10, 2025
14 tasks
@MiguelCompany MiguelCompany added this to the v3.3.1 milestone Sep 10, 2025
@cferreiragonz
Copy link
Contributor

@Mergifyio rebase

* Release change while authentication fails

Signed-off-by: Barry Xu <barry.xu@sony.com>

* Fix uncrustify error

Signed-off-by: Barry Xu <barry.xu@sony.com>

* Refs #23431: Refactor PubSubReader/Writer (un)authorized() methods

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #23431: Add regression test

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #23431: Apply Miguel's suggestions

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #23431: Fix windows compilation

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #23431: Uncrustify

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Fix a memory leak on handshake handle

Signed-off-by: Barry Xu <barry.xu@sony.com>

* Fix an Uncrustify error

Signed-off-by: Barry Xu <barry.xu@sony.com>

---------

Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit db64a12)
@mergify
Copy link
Contributor Author

mergify bot commented Nov 12, 2025

rebase

✅ Branch has been successfully rebased

@cferreiragonz cferreiragonz force-pushed the mergify/bp/3.3.x/pr-5935 branch from 86e2de7 to c1f2668 Compare November 12, 2025 09:10
@github-actions github-actions bot added the ci-pending PR which CI is running label Nov 12, 2025
@cferreiragonz cferreiragonz removed the request for review from richiprosima November 12, 2025 09:12
@mergify
Copy link
Contributor Author

mergify bot commented Nov 12, 2025

🧪 CI Insights

Here's what we observed from your CI run for c1f2668.

❌ Job Failures

Pipeline Job Health on 3.3.x Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, examples), v142 Unknown 0 View View
windows-ci / fastdds_test (RelWithDebInfo, examples), v143 Unknown 0 View View

@cferreiragonz cferreiragonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Nov 13, 2025
@juanlofer-eprosima juanlofer-eprosima merged commit 5055dec into 3.3.x Nov 13, 2025
25 of 28 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the mergify/bp/3.3.x/pr-5935 branch November 13, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants