Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 10, 2025

Description

Address #5934

particiapant_stateless_message_writer_history should be properly freed when authentication fails.

@Mergifyio backport 3.3.x 3.2.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • Any new/modified methods have been properly documented using Doxygen.

  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5935 done by [Mergify](https://mergify.com).

@mergify mergify bot mentioned this pull request Sep 10, 2025
14 tasks
@MiguelCompany MiguelCompany added this to the v2.14.6 milestone Sep 10, 2025
@emiliocuestaf emiliocuestaf self-requested a review September 15, 2025 13:55
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 15, 2025
Copy link
Contributor Author

mergify bot commented Sep 15, 2025

🧪 CI Insights

Here's what we observed from your CI run for d47cd75.

❌ Job Failures

Pipeline Job Health on 2.14.x Retries 🔍 CI Insights 📄 Logs
Fast DDS Sanitizers CI sanitizers-ci / asan_fastdds_test Unknown 0 View View
sanitizers-ci / tsan_fastdds_test Unknown 0 View View
Fast-DDS MacOS CI mac-ci / reusable-mac-ci (RelWithDebInfo) Unknown 0 View View
Fast-DDS Windows CI windows-ci / reusable-windows-ci (RelWithDebInfo, v142) Unknown 0 View View
windows-ci / reusable-windows-ci (RelWithDebInfo, v143) Unknown 0 View View

* Release change while authentication fails

Signed-off-by: Barry Xu <[email protected]>

* Fix uncrustify error

Signed-off-by: Barry Xu <[email protected]>

* Refs #23431: Refactor PubSubReader/Writer (un)authorized() methods

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #23431: Add regression test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #23431: Apply Miguel's suggestions

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #23431: Fix windows compilation

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #23431: Uncrustify

Signed-off-by: Mario Dominguez <[email protected]>

* Fix a memory leak on handshake handle

Signed-off-by: Barry Xu <[email protected]>

* Fix an Uncrustify error

Signed-off-by: Barry Xu <[email protected]>

---------

Signed-off-by: Barry Xu <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Co-authored-by: Mario Dominguez <[email protected]>
(cherry picked from commit db64a12)
@emiliocuestaf emiliocuestaf force-pushed the mergify/bp/2.14.x/pr-5935 branch from 51dd052 to d47cd75 Compare September 29, 2025 13:30
@emiliocuestaf emiliocuestaf removed the ci-pending PR which CI is running label Sep 29, 2025
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants