Skip to content

[23703] Remove support for @feed operations #6052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 26, 2025
Merged

[23703] Remove support for @feed operations #6052

merged 5 commits into from
Sep 26, 2025

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Sep 19, 2025 •
edited by rsanchez15
Loading

Description

This removes @feed operations from the RPC example, since this becomes a Fast DDS Pro feature

@Mergifyio backport 3.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A: Changes are API compatible.
    • Though technically there's an API break in removing public headers, they are being added to Fast DDS Pro
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.4.0 milestone Sep 19, 2025
@MiguelCompany MiguelCompany mentioned this pull request Sep 19, 2025
Merged
8 tasks
@Carlosespicur Carlosespicur marked this pull request as ready for review September 23, 2025 12:47
@Carlosespicur Carlosespicur self-requested a review September 23, 2025 12:47
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 23, 2025
Carlosespicur
Carlosespicur requested changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@Carlosespicur Carlosespicur left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update README.md and remove InputFeedProcessor class in RPC example.

@MiguelCompany MiguelCompany force-pushed the feature/23701 branch 2 times, most recently from 46cde77 to 86a5f2a Compare September 24, 2025 13:02
Carlosespicur
Carlosespicur previously approved these changes Sep 25, 2025
View reviewed changes
rsanchez15
rsanchez15 approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests not related to this PR

@MiguelCompany MiguelCompany merged commit 0ff6c95 into master Sep 26, 2025
35 of 39 checks passed
@MiguelCompany MiguelCompany deleted the feature/23701 branch September 26, 2025 07:43
@MiguelCompany
Copy link
Member Author

@Mergifyio backport 3.2.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 26, 2025 •
edited
Loading

backport 3.2.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 26, 2025
@MiguelCompany @mergify
Remove support for @feed operations (#6052)
3f94f5b 
* Refs #23701. Remove feed readers and writers.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23701. Remove feed operations from example.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23701. Update readme.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23701. Remove `InputFeedProcessor`.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23703. Remove unsupported cases from example test.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 0ff6c95)

# Conflicts:
#	examples/cpp/rpc/ServerApp.cpp
#	examples/cpp/rpc/ServerApp.hpp
#	examples/cpp/rpc/types/calculatorServer.cxx
#	examples/cpp/rpc/types/calculatorServer.hpp
#	examples/cpp/rpc/types/calculatorServerImpl.hpp
#	examples/cpp/rpc/types/calculatorTypeObjectSupport.cxx
#	examples/cpp/rpc/types/calculatorTypeObjectSupport.hpp
#	include/fastdds/dds/rpc/interfaces.hpp
@mergify mergify bot mentioned this pull request Sep 26, 2025
Merged
10 tasks
MiguelCompany added a commit that referenced this pull request Oct 1, 2025
@mergify @MiguelCompany
Remove RPC example (#6059)
e348906 
* Remove support for `@feed` operations (#6052)

* Refs #23701. Remove feed readers and writers.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23701. Remove feed operations from example.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23701. Update readme.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23701. Remove `InputFeedProcessor`.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23703. Remove unsupported cases from example test.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 0ff6c95)

# Conflicts:
#	examples/cpp/rpc/ServerApp.cpp
#	examples/cpp/rpc/ServerApp.hpp
#	examples/cpp/rpc/types/calculatorServer.cxx
#	examples/cpp/rpc/types/calculatorServer.hpp
#	examples/cpp/rpc/types/calculatorServerImpl.hpp
#	examples/cpp/rpc/types/calculatorTypeObjectSupport.cxx
#	examples/cpp/rpc/types/calculatorTypeObjectSupport.hpp
#	include/fastdds/dds/rpc/interfaces.hpp

* Fix basic conflicts.

Signed-off-by: Miguel Company <[email protected]>

* Completely remove example.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsanchez15 rsanchez15 rsanchez15 approved these changes

@Carlosespicur Carlosespicur Awaiting requested review from Carlosespicur

Assignees
No one assigned
Labels
ci-pending PR which CI is running fast dds pro
Projects
None yet
Milestone
v3.4.0 - Frozen ❄️
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @rsanchez15 @Carlosespicur