Skip to content

[23654] Change non_blocking_send threshold to sendBufferSize#6073

Merged
rsanchez15 merged 1 commit intomasterfrom
bugfix/23654
Oct 7, 2025
Merged

[23654] Change non_blocking_send threshold to sendBufferSize#6073
rsanchez15 merged 1 commit intomasterfrom
bugfix/23654

Conversation

@juanlofer-eprosima
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima commented Oct 2, 2025

Description

Currently the non blocking size feature assumes that the size of TCP sockets allocated by the OS is twice the value requested (sendBufferSize). However, it has been observed that the actual reserved value may fall below that value, hence blocking when the buffer gets full and ruining the purpose of this feature.

@Mergifyio backport 3.3.x 3.2.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/a Any new/modified methods have been properly documented using Doxygen.
  • N/a Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/a New feature has been added to the versions.md file (if applicable).
  • N/a New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@juanlofer-eprosima juanlofer-eprosima added this to the v3.4.1 milestone Oct 2, 2025
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 2, 2025
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2025

🧪 CI Insights

Here's what we observed from your CI run for 8f86a2f.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS Ubuntu CI ubuntu-ci / fastdds_build (RelWithDebInfo) Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although it really surprises me that ubuntu-ci failed twice. I am re-running it just in case

@cferreiragonz cferreiragonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Oct 7, 2025
@cferreiragonz
Copy link
Contributor

Let's assume failed tests in previous runs were unrelated. I was not able to reproduce them locally

@rsanchez15 rsanchez15 merged commit 81a5b12 into master Oct 7, 2025
42 of 45 checks passed
@rsanchez15 rsanchez15 deleted the bugfix/23654 branch October 7, 2025 06:55
@juanlofer-eprosima
Copy link
Contributor Author

https://github.com/Mergifyio backport 3.3.x 3.2.x 2.14.x

@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2025

backport 3.3.x 3.2.x 2.14.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Oct 7, 2025
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
(cherry picked from commit 81a5b12)
mergify bot pushed a commit that referenced this pull request Oct 7, 2025
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
(cherry picked from commit 81a5b12)
mergify bot pushed a commit that referenced this pull request Oct 7, 2025
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
(cherry picked from commit 81a5b12)

# Conflicts:
#	test/unittest/transport/TCPv4Tests.cpp
#	test/unittest/transport/TCPv6Tests.cpp
juanlofer-eprosima added a commit that referenced this pull request Oct 7, 2025
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
(cherry picked from commit 81a5b12)

# Conflicts:
#	test/unittest/transport/TCPv4Tests.cpp
#	test/unittest/transport/TCPv6Tests.cpp
juanlofer-eprosima added a commit that referenced this pull request Oct 8, 2025
(cherry picked from commit 81a5b12)

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Co-authored-by: juanlofer-eprosima <88179026+juanlofer-eprosima@users.noreply.github.com>
juanlofer-eprosima added a commit that referenced this pull request Oct 8, 2025
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
(cherry picked from commit 81a5b12)

# Conflicts:
#	test/unittest/transport/TCPv4Tests.cpp
#	test/unittest/transport/TCPv6Tests.cpp

Co-authored-by: juanlofer-eprosima <88179026+juanlofer-eprosima@users.noreply.github.com>
juanlofer-eprosima added a commit that referenced this pull request Oct 9, 2025
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
(cherry picked from commit 81a5b12)
juanlofer-eprosima added a commit that referenced this pull request Oct 9, 2025
(cherry picked from commit 81a5b12)

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Co-authored-by: juanlofer-eprosima <88179026+juanlofer-eprosima@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants