[23654] Change non_blocking_send threshold to sendBufferSize#6073
Merged
rsanchez15 merged 1 commit intomasterfrom Oct 7, 2025
Merged
[23654] Change non_blocking_send threshold to sendBufferSize#6073rsanchez15 merged 1 commit intomasterfrom
rsanchez15 merged 1 commit intomasterfrom
Conversation
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
7c2a431 to
8f86a2f
Compare
Contributor
🧪 CI InsightsHere's what we observed from your CI run for 8f86a2f. ❌ Job Failures
✅ Passed Jobs With Interesting Signals
|
cferreiragonz
approved these changes
Oct 6, 2025
Contributor
cferreiragonz
left a comment
There was a problem hiding this comment.
LGTM, although it really surprises me that ubuntu-ci failed twice. I am re-running it just in case
Contributor
|
Let's assume failed tests in previous runs were unrelated. I was not able to reproduce them locally |
Contributor
Author
|
https://github.com/Mergifyio backport 3.3.x 3.2.x 2.14.x |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2025
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> (cherry picked from commit 81a5b12)
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2025
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> (cherry picked from commit 81a5b12)
This was referenced Oct 7, 2025
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2025
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> (cherry picked from commit 81a5b12) # Conflicts: # test/unittest/transport/TCPv4Tests.cpp # test/unittest/transport/TCPv6Tests.cpp
12 tasks
juanlofer-eprosima
added a commit
that referenced
this pull request
Oct 7, 2025
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> (cherry picked from commit 81a5b12) # Conflicts: # test/unittest/transport/TCPv4Tests.cpp # test/unittest/transport/TCPv6Tests.cpp
juanlofer-eprosima
added a commit
that referenced
this pull request
Oct 8, 2025
juanlofer-eprosima
added a commit
that referenced
this pull request
Oct 8, 2025
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> (cherry picked from commit 81a5b12) # Conflicts: # test/unittest/transport/TCPv4Tests.cpp # test/unittest/transport/TCPv6Tests.cpp Co-authored-by: juanlofer-eprosima <88179026+juanlofer-eprosima@users.noreply.github.com>
juanlofer-eprosima
added a commit
that referenced
this pull request
Oct 9, 2025
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> (cherry picked from commit 81a5b12)
juanlofer-eprosima
added a commit
that referenced
this pull request
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the non blocking size feature assumes that the size of TCP sockets allocated by the OS is twice the value requested (sendBufferSize). However, it has been observed that the actual reserved value may fall below that value, hence blocking when the buffer gets full and ruining the purpose of this feature.
@Mergifyio backport 3.3.x 3.2.x 2.14.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist