Skip to content

[23777] Guard gnu::optimize with defined(__GNUC__)#6080

Merged
MiguelCompany merged 1 commit intomasterfrom
bugfix/23620
Oct 15, 2025
Merged

[23777] Guard gnu::optimize with defined(__GNUC__)#6080
MiguelCompany merged 1 commit intomasterfrom
bugfix/23620

Conversation

@MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Oct 7, 2025 •
edited by cferreiragonz
Loading

Description

This should fix this OSS Fuzz issue by guarding a GNU specific attribute with the corresponding guard.

@Mergifyio backport 3.3.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.4.1 milestone Oct 7, 2025
@MiguelCompany MiguelCompany changed the title [23620] Guard gnu::optimize with defined(__GNUC__) [23777] Guard gnu::optimize with defined(__GNUC__) Oct 7, 2025
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Oct 7, 2025
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 7, 2025
@MiguelCompany MiguelCompany removed the request for review from richiprosima October 7, 2025 14:10
@MiguelCompany
Refs #23620. Guard gnu::optimize with defined(__GNUC__)
d026417 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
cferreiragonz
cferreiragonz approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cferreiragonz
Copy link
Contributor

cferreiragonz commented Oct 14, 2025

I believe we should backport it only to 3.3.x

@cferreiragonz cferreiragonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Oct 14, 2025
@MiguelCompany MiguelCompany merged commit e7625c3 into master Oct 15, 2025
18 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/23620 branch October 15, 2025 08:39
@MiguelCompany
Copy link
Member Author

MiguelCompany commented Oct 15, 2025

@Mergifyio backport 3.3.x

@mergify
Copy link
Contributor

mergify bot commented Oct 15, 2025 •
edited
Loading

backport 3.3.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Oct 15, 2025
@MiguelCompany @mergify
Guard gnu::optimize with defined(__GNUC__) (#6080)
227a2aa 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit e7625c3)
@mergify mergify bot mentioned this pull request Oct 15, 2025
Merged
10 tasks
MiguelCompany added a commit that referenced this pull request Oct 17, 2025
@mergify @MiguelCompany
Guard gnu::optimize with defined(__GNUC__) (#6080) (#6101)
42042d5 
(cherry picked from commit e7625c3)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cferreiragonz cferreiragonz cferreiragonz approved these changes

Assignees

No one assigned

Labels

no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Milestone

v3.4.1 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@MiguelCompany @cferreiragonz