[23847] Protect DataReaderInstance alive_writers attribute

[juanlofer-eprosima]

Description

This PR attempts to solve the data race produced in intraprocess scenario, when a writer sends a message from a thread (which updates its associated instance state in the reader receiving the message: DataReaderImpl::on_new_cache_change_added → DataReaderHistory::update_instance_nts → … → DataReaderInstance::writer_set), while from another thread the instances state of the same reader is also updated without protection (e.g., when destroying a matched writer: DataReaderImpl::update_subscription_matched_status → … → DataReaderInstance::writer_unregister). In the first thread the reader mutex is taken before calling update_instance_nts, the problem is that in the second thread that mutex is never taken.

@Mergifyio backport 3.3.x 3.2.x 2.14.x

Contributor Checklist

• Commit messages follow the project guidelines.
• The code follows the style guidelines of this project.
• Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
• N/A Any new/modified methods have been properly documented using Doxygen.
• N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
• Changes are backport compatible: they do NOT break ABI nor change library core behavior.
• Changes are API compatible.
• N/A New feature has been added to the versions.md file (if applicable).
• N/A New feature has been documented/Current behavior is correctly described in the documentation.
• Applicable backports have been included in the description.

Reviewer Checklist

• The PR has a milestone assigned.
• The title and description correctly express the PR's purpose.
• Check contributor checklist is correct.
• If this is a critical bug fix, backports to the critical-only supported branches have been requested.
• Check CI results: changes do not issue any warning.
• Check CI results: failing tests are unrelated with the changes.

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for 976ba43.

❌ Job Failures

Pipeline	Job	Health on master	Retries	🔍 CI Insights	📄 Logs
Fast DDS MacOS CI	mac-ci / fastdds_test ()		0	View	View
Fast DDS Windows CI	windows-ci / fastdds_test (RelWithDebInfo, examples), v142		0	View	View
	windows-ci / fastdds_test (RelWithDebInfo, examples), v143		0	View	View

[MiguelCompany]

LGTM with green CI

[MiguelCompany]

@Mergifyio backport 3.3.x 3.2.x 2.14.x

[mergify]

backport 3.3.x 3.2.x 2.14.x

✅ Backports have been created

Details

• #6158 [23847] Protect DataReaderInstance alive_writers attribute (backport #6123) has been created for branch 3.3.x
• #6159 [23847] Protect DataReaderInstance alive_writers attribute (backport #6123) has been created for branch 3.2.x but encountered conflicts
• #6160 [23847] Protect DataReaderInstance alive_writers attribute (backport #6123) has been created for branch 2.14.x but encountered conflicts