[23929] Allow to send empty payloads in dispose/unregister ops by emiliocuestaf · Pull Request #6217 · eProsima/Fast-DDS

emiliocuestaf · 2025-12-12T17:10:38Z

Description

This pull request improves the handling of dispose and unregister operations when payloads are empty, and enhances test coverage for these scenarios. Until now, it was not possible to send those messages with empty payloads, now it is allowed as long as a valid instance handle is provided.

Update DataWriterImpl to be able to write Unregister/Dispose messages with empty payloads.
Add tests for the case above
Update RTPSStatelessReader to be able to read Unregister/Dispose messages with empty payloads.
Add tests for the case above
Update RTPSStatefulReader to be able to read Unregister/Dispose messages with empty payloads.
Add tests for the case above
Modified topic_instances example to correctly print the color name even when no payload is passed.

@Mergifyio backport 3.4.x 3.3.x 3.2.x 2.14.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the versions.md file (if applicable).
N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

mergify · 2025-12-13T00:02:37Z

🧪 CI Insights

Here's what we observed from your CI run for 4fd2db9.

❌ Job Failures

Pipeline	Job	Retries	🔍 CI Insights	📄 Logs
`Fast DDS MacOS CI`	`mac-ci / fastdds_test ()`	`2`	View	View
`Fast DDS Windows CI`	`windows-ci / fastdds_test (RelWithDebInfo, examples), v142`	`1`	View	View
`Fast DDS Windows CI`	`windows-ci / fastdds_test (RelWithDebInfo, examples), v143`	`0`	View	View

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

…same color on dispose Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

MiguelCompany

LGTM with green CI

MiguelCompany · 2026-01-08T06:48:36Z

@Mergifyio backport 3.4.x 3.3.x 3.2.x 2.14.x

mergify · 2026-01-08T06:48:45Z

backport 3.4.x 3.3.x 3.2.x 2.14.x

✅ Backports have been created

Details

#6235 [23929] Allow to send empty payloads in dispose/unregister ops (backport #6217) has been created for branch 3.4.x
#6236 [23929] Allow to send empty payloads in dispose/unregister ops (backport #6217) has been created for branch 3.3.x but encountered conflicts
#6237 [23929] Allow to send empty payloads in dispose/unregister ops (backport #6217) has been created for branch 3.2.x but encountered conflicts
#6238 [23929] Allow to send empty payloads in dispose/unregister ops (backport #6217) has been created for branch 2.14.x but encountered conflicts

* Allowing to send empty payloads in dispose/unregister ops Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Refactor to keep current execution path for most cases Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Making readers able to read empty paoload messages Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding tests for RTPS readers Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix trace logging in topic_instances example, that always showed the same color on dispose Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Make writer write empty payload only if get_payload fails Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Late disposes are not received in history and cause segfault when freed Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix asan problems Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Apply easy suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Apply revision part2 Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Update src/cpp/fastdds/publisher/DataWriterImpl.cpp Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Replace old signature name Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Remove unnecessary check Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding assert in case that should not happen Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Removing line Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 47bfac0)

* Allowing to send empty payloads in dispose/unregister ops Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Refactor to keep current execution path for most cases Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Making readers able to read empty paoload messages Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding tests for RTPS readers Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix trace logging in topic_instances example, that always showed the same color on dispose Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Make writer write empty payload only if get_payload fails Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Late disposes are not received in history and cause segfault when freed Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix asan problems Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Apply easy suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Apply revision part2 Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Update src/cpp/fastdds/publisher/DataWriterImpl.cpp Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Replace old signature name Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Remove unnecessary check Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding assert in case that should not happen Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Removing line Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 47bfac0) # Conflicts: # test/unittest/dds/publisher/DataWriterTests.cpp

* Allowing to send empty payloads in dispose/unregister ops Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Refactor to keep current execution path for most cases Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Making readers able to read empty paoload messages Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding tests for RTPS readers Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix trace logging in topic_instances example, that always showed the same color on dispose Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Make writer write empty payload only if get_payload fails Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Late disposes are not received in history and cause segfault when freed Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix asan problems Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Apply easy suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Apply revision part2 Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Update src/cpp/fastdds/publisher/DataWriterImpl.cpp Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Replace old signature name Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Remove unnecessary check Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding assert in case that should not happen Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Removing line Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 47bfac0) # Conflicts: # examples/cpp/topic_instances/SubscriberApp.cpp # examples/cpp/topic_instances/SubscriberApp.hpp # src/cpp/fastdds/publisher/DataWriterImpl.cpp # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/unittest/dds/publisher/DataWriterTests.cpp # test/unittest/rtps/reader/CMakeLists.txt # test/unittest/rtps/reader/StatefulReaderTests.cpp

* Allowing to send empty payloads in dispose/unregister ops Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Refactor to keep current execution path for most cases Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Making readers able to read empty paoload messages Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding tests for RTPS readers Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix trace logging in topic_instances example, that always showed the same color on dispose Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Make writer write empty payload only if get_payload fails Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Late disposes are not received in history and cause segfault when freed Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix asan problems Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Apply easy suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Apply revision part2 Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Update src/cpp/fastdds/publisher/DataWriterImpl.cpp Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Replace old signature name Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Remove unnecessary check Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding assert in case that should not happen Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Removing line Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 47bfac0) # Conflicts: # test/unittest/dds/publisher/DataWriterTests.cpp

* Allowing to send empty payloads in dispose/unregister ops Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Refactor to keep current execution path for most cases Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Making readers able to read empty paoload messages Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding tests for RTPS readers Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix trace logging in topic_instances example, that always showed the same color on dispose Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Make writer write empty payload only if get_payload fails Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Late disposes are not received in history and cause segfault when freed Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix asan problems Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Apply easy suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Apply revision part2 Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Update src/cpp/fastdds/publisher/DataWriterImpl.cpp Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Replace old signature name Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Remove unnecessary check Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding assert in case that should not happen Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Removing line Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 47bfac0) # Conflicts: # examples/cpp/topic_instances/SubscriberApp.cpp # examples/cpp/topic_instances/SubscriberApp.hpp # src/cpp/fastdds/publisher/DataWriterImpl.cpp # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/unittest/dds/publisher/DataWriterTests.cpp # test/unittest/rtps/reader/CMakeLists.txt # test/unittest/rtps/reader/StatefulReaderTests.cpp

* Allow empty payloads in dispose/unregister operations (#6217) * Allowing to send empty payloads in dispose/unregister ops Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Refactor to keep current execution path for most cases Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Making readers able to read empty paoload messages Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding tests for RTPS readers Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix trace logging in topic_instances example, that always showed the same color on dispose Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Make writer write empty payload only if get_payload fails Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Late disposes are not received in history and cause segfault when freed Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix asan problems Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Apply easy suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Apply revision part2 Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Update src/cpp/fastdds/publisher/DataWriterImpl.cpp Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Replace old signature name Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Remove unnecessary check Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding assert in case that should not happen Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Removing line Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 47bfac0) # Conflicts: # test/unittest/dds/publisher/DataWriterTests.cpp * Solve conflicts Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Link against Mac base libraries Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Uncrustify to backport Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> --------- Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>

* Allowing to send empty payloads in dispose/unregister ops Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Refactor to keep current execution path for most cases Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Making readers able to read empty paoload messages Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding tests for RTPS readers Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix trace logging in topic_instances example, that always showed the same color on dispose Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Make writer write empty payload only if get_payload fails Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Late disposes are not received in history and cause segfault when freed Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix asan problems Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Apply easy suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Apply revision part2 Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Update src/cpp/fastdds/publisher/DataWriterImpl.cpp Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Replace old signature name Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Remove unnecessary check Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding assert in case that should not happen Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Removing line Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 47bfac0) # Conflicts: # examples/cpp/topic_instances/SubscriberApp.cpp # examples/cpp/topic_instances/SubscriberApp.hpp # src/cpp/fastdds/publisher/DataWriterImpl.cpp # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/unittest/dds/publisher/DataWriterTests.cpp # test/unittest/rtps/reader/CMakeLists.txt # test/unittest/rtps/reader/StatefulReaderTests.cpp

* Allowing to send empty payloads in dispose/unregister ops * Add tests * Uncrustify * Refactor to keep current execution path for most cases * Making readers able to read empty paoload messages * Adding tests for RTPS readers * Fix trace logging in topic_instances example, that always showed the same color on dispose * Uncrustify * Make writer write empty payload only if get_payload fails * Late disposes are not received in history and cause segfault when freed * Fix asan problems * Apply easy suggestions from code review * Apply revision part2 * Update src/cpp/fastdds/publisher/DataWriterImpl.cpp * Replace old signature name * Remove unnecessary check * Adding assert in case that should not happen * Removing line --------- (cherry picked from commit 47bfac0) Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> Co-authored-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

* Allow empty payloads in dispose/unregister operations (#6217) * Allowing to send empty payloads in dispose/unregister ops Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Refactor to keep current execution path for most cases Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Making readers able to read empty paoload messages Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding tests for RTPS readers Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix trace logging in topic_instances example, that always showed the same color on dispose Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Make writer write empty payload only if get_payload fails Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Late disposes are not received in history and cause segfault when freed Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix asan problems Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Apply easy suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Apply revision part2 Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Update src/cpp/fastdds/publisher/DataWriterImpl.cpp Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Replace old signature name Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Remove unnecessary check Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding assert in case that should not happen Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Removing line Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 47bfac0) # Conflicts: # examples/cpp/topic_instances/SubscriberApp.cpp # examples/cpp/topic_instances/SubscriberApp.hpp # src/cpp/fastdds/publisher/DataWriterImpl.cpp # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/unittest/dds/publisher/DataWriterTests.cpp # test/unittest/rtps/reader/CMakeLists.txt # test/unittest/rtps/reader/StatefulReaderTests.cpp * Fix src conflicts Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix tests and uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Attempt to fick mock test Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Undo changes in CacheChange.h Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Attempt to fix windows issue with minmax Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix mac compilation issue Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Apply suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Remove topic_instances example Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Undo namespace replacement Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> Co-authored-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

* Allow empty payloads in dispose/unregister operations (#6217) * Allowing to send empty payloads in dispose/unregister ops Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Refactor to keep current execution path for most cases Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Making readers able to read empty paoload messages Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding tests for RTPS readers Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix trace logging in topic_instances example, that always showed the same color on dispose Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Make writer write empty payload only if get_payload fails Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Late disposes are not received in history and cause segfault when freed Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix asan problems Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Apply easy suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Apply revision part2 Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Update src/cpp/fastdds/publisher/DataWriterImpl.cpp Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Replace old signature name Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Remove unnecessary check Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding assert in case that should not happen Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Removing line Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 47bfac0) # Conflicts: # test/unittest/dds/publisher/DataWriterTests.cpp * Fix conflicts Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix bad linkage of Mac dependencies in tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix target_link_libraries for StatelessReaderTests Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

Allowing to send empty payloads in dispose/unregister ops

e190b40

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

emiliocuestaf requested a review from richiprosima December 12, 2025 17:10

github-actions bot added the ci-pending PR which CI is running label Dec 12, 2025

Add tests

a3b8dc6

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

emiliocuestaf force-pushed the feature/empty-payload-dispose-unregister branch from 02fffeb to a3b8dc6 Compare December 15, 2025 06:27

Uncrustify

80ce792

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

emiliocuestaf requested review from richiprosima and removed request for richiprosima December 15, 2025 22:52

Refactor to keep current execution path for most cases

8f0f0c3

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

emiliocuestaf requested review from richiprosima and removed request for richiprosima December 16, 2025 08:20

Making readers able to read empty paoload messages

e6520f2

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

emiliocuestaf requested review from richiprosima and removed request for richiprosima December 17, 2025 10:31

emiliocuestaf changed the title ~~Allow to send empty payloads in dispose/unregister ops~~ [#23929] Allow to send empty payloads in dispose/unregister ops Dec 17, 2025

emiliocuestaf added 2 commits December 17, 2025 16:11

Adding tests for RTPS readers

922dff0

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

Fix trace logging in topic_instances example, that always showed the …

d5a0e41

…same color on dispose Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

emiliocuestaf added this to the v3.5.0 milestone Dec 17, 2025

Uncrustify

14201d9

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

emiliocuestaf requested review from richiprosima and removed request for richiprosima December 17, 2025 16:32

emiliocuestaf mentioned this pull request Dec 17, 2025

[23929] Forward unregister and dispose messages eProsima/DDS-Pipe#172

Merged

Make writer write empty payload only if get_payload fails

d6f9c59

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

emiliocuestaf requested review from richiprosima and removed request for richiprosima December 18, 2025 06:54

emiliocuestaf marked this pull request as ready for review December 18, 2025 07:35

Late disposes are not received in history and cause segfault when freed

a647584

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

emiliocuestaf requested review from richiprosima and removed request for richiprosima December 18, 2025 11:33

Remove unnecessary check

7059b99

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

emiliocuestaf dismissed MiguelCompany’s stale review via 7059b99 January 7, 2026 14:16

emiliocuestaf requested a review from MiguelCompany January 7, 2026 14:17

Adding assert in case that should not happen

9972a92

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

emiliocuestaf requested a review from richiprosima January 7, 2026 14:31

Removing line

4fd2db9

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany and richiprosima January 7, 2026 14:35

MiguelCompany approved these changes Jan 7, 2026

View reviewed changes

MiguelCompany merged commit 47bfac0 into master Jan 8, 2026
45 of 56 checks passed

MiguelCompany deleted the feature/empty-payload-dispose-unregister branch January 8, 2026 06:48

This was referenced Jan 8, 2026

[23929] Allow to send empty payloads in dispose/unregister ops (backport #6217) #6235

Merged

[23929] Allow to send empty payloads in dispose/unregister ops (backport #6217) #6236

Merged

mergify bot mentioned this pull request Jan 8, 2026

[23929] Allow to send empty payloads in dispose/unregister ops (backport #6217) #6237

Merged

10 tasks

mergify bot mentioned this pull request Jan 8, 2026

[23929] Allow to send empty payloads in dispose/unregister ops (backport #6217) #6238

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[23929] Allow to send empty payloads in dispose/unregister ops#6217

[23929] Allow to send empty payloads in dispose/unregister ops#6217
MiguelCompany merged 18 commits intomasterfrom
feature/empty-payload-dispose-unregister

emiliocuestaf commented Dec 12, 2025 •

edited by MiguelCompany

Loading

Uh oh!

mergify bot commented Dec 13, 2025 •

edited

Loading

Uh oh!

MiguelCompany left a comment

Uh oh!

Uh oh!

MiguelCompany commented Jan 8, 2026

Uh oh!

mergify bot commented Jan 8, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

emiliocuestaf commented Dec 12, 2025 • edited by MiguelCompany Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

mergify bot commented Dec 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 CI Insights

❌ Job Failures

Uh oh!

MiguelCompany left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MiguelCompany commented Jan 8, 2026

Uh oh!

mergify bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

emiliocuestaf commented Dec 12, 2025 •

edited by MiguelCompany

Loading

mergify bot commented Dec 13, 2025 •

edited

Loading

mergify bot commented Jan 8, 2026 •

edited

Loading