Skip to content

[24037] Fix usage of invalid interator in DynamicDataImpl::deserialize()#6227

Merged
richiware merged 1 commit intomasterfrom
bugfix/24036
Jan 7, 2026
Merged

[24037] Fix usage of invalid interator in DynamicDataImpl::deserialize()#6227
richiware merged 1 commit intomasterfrom
bugfix/24036

Conversation

@richiware
Copy link
Copy Markdown
Member

@richiware richiware commented Dec 31, 2025 •
edited by MiguelCompany
Loading

Description

Fixes #6224.

@Mergifyio backport 3.4.x 3.3.x 3.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware
Refs #24036. Fix
59622b9 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware changed the title Fix usage of invalid interator in DynamicDataImpl::deserialize() [24037] Fix usage of invalid interator in DynamicDataImpl::deserialize() Dec 31, 2025
@juanlofer-eprosima juanlofer-eprosima added this to the v3.4.2 milestone Dec 31, 2025
@juanlofer-eprosima juanlofer-eprosima requested review from richiprosima and removed request for richiprosima December 31, 2025 09:52
@github-actions github-actions bot added the ci-pending PR which CI is running label Dec 31, 2025
juanlofer-eprosima
juanlofer-eprosima approved these changes Dec 31, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 31, 2025

🧪 CI Insights

Here's what we observed from your CI run for 59622b9.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, examples), v142 Unknown 0 View View

@richiware richiware modified the milestones: v3.4.2, v3.5.0 Jan 7, 2026
@richiware richiware merged commit abbe86f into master Jan 7, 2026
26 of 28 checks passed
@richiware richiware deleted the bugfix/24036 branch January 7, 2026 07:14
@MiguelCompany
Copy link
Copy Markdown
Member

MiguelCompany commented Jan 7, 2026

@Mergifyio backport 3.4.x 3.3.x 3.2.x

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 7, 2026 •
edited
Loading

backport 3.4.x 3.3.x 3.2.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jan 7, 2026
@richiware @mergify
Fix usage of invalid interator in DynamicDataImpl::deserialize() (#6227)
006efae 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
(cherry picked from commit abbe86f)
mergify bot pushed a commit that referenced this pull request Jan 7, 2026
@richiware @mergify
Fix usage of invalid interator in DynamicDataImpl::deserialize() (#6227)
e571b1a 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
(cherry picked from commit abbe86f)
This was referenced Jan 7, 2026
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jan 7, 2026
@richiware @mergify
Fix usage of invalid interator in DynamicDataImpl::deserialize() (#6227)
a43ff96 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
(cherry picked from commit abbe86f)
@mergify mergify bot mentioned this pull request Jan 7, 2026
Merged
10 tasks
MiguelCompany pushed a commit that referenced this pull request Jan 7, 2026
@mergify @richiware
Fix usage of invalid interator in DynamicDataImpl::deserialize() (#6227…
2661698 
…) (#6230)

(cherry picked from commit abbe86f)

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Co-authored-by: Ricardo González <ricardo@richiware.dev>
MiguelCompany pushed a commit that referenced this pull request Jan 7, 2026
@mergify @richiware
Fix usage of invalid interator in DynamicDataImpl::deserialize() (#6227…
7851c7f 
…) (#6232)

(cherry picked from commit abbe86f)

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Co-authored-by: Ricardo González <ricardo@richiware.dev>
MiguelCompany pushed a commit that referenced this pull request Jan 7, 2026
@mergify @richiware
Fix usage of invalid interator in DynamicDataImpl::deserialize() (#6227…
2279f8a 
…) (#6231)

(cherry picked from commit abbe86f)

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Co-authored-by: Ricardo González <ricardo@richiware.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juanlofer-eprosima juanlofer-eprosima juanlofer-eprosima approved these changes

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v3.5.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

Bug in DynamicDataImpl::deserialize() when the struct type has no member with the specified id in type

3 participants

@richiware @MiguelCompany @juanlofer-eprosima