[WIP] Notify readers about participant internal writers#6307
Draft
pwueje wants to merge 1 commit intoeProsima:masterfrom
Draft
[WIP] Notify readers about participant internal writers#6307pwueje wants to merge 1 commit intoeProsima:masterfrom
pwueje wants to merge 1 commit intoeProsima:masterfrom
Conversation
a358855 to
9c6908b
Compare
1 task
Previously, readers didn't get liveliness updates on writers within the same participant using the automatic lifetime. This caused instances to get disposed, even if the writer was still alive. This change notifies the local readers in the similiar way as this is the case for readers on a different participant. Signed-off-by: Philipp Jeske <philipp.jeske@iqsight.com> Co-authored-by: Matthias Schneider <matthias.schneider6@iqsight.com>
9c6908b to
bb09f2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, readers didn't get liveliness updates on writers within the same participant using the automatic lifetime. This caused instances to get disposed, even if the writer was still alive.
This change notifies the local readers in the similiar way as this is the case for readers on a different participant.
@Mergifyio backport 3.4.x 3.2.x
Fixes #6306
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist