Skip to content

[24182] Extend DomainParticipant API to include return codes#6314

Open
emiliocuestaf wants to merge 4 commits intofast/rpc-refactorfrom
feature/create-api-extension
Open

[24182] Extend DomainParticipant API to include return codes#6314
emiliocuestaf wants to merge 4 commits intofast/rpc-refactorfrom
feature/create-api-extension

Conversation

@emiliocuestaf
Copy link
Contributor

@emiliocuestaf emiliocuestaf commented Feb 19, 2026

Description

This PR extends the public API of DomainParticipant.h to include "create_X(..., RetCode_t &ret, ...)" functions, which have the return code as an output argument.

This PR depends on #6308 and must be merged after that one. That PR already extended the API for the RPC-related entities, this is just a continuation of that work. Once it has been merged, please do a git rebase --onto to correctly squash all the commits coming from that PR as done in master.

As a consequence, any reviewer should only review from commit ed8b654 on. I'm sorry for the inconvenience.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@emiliocuestaf emiliocuestaf added this to the v3.5.0 milestone Feb 19, 2026
@github-actions github-actions bot added the ci-pending PR which CI is running label Feb 19, 2026
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@emiliocuestaf emiliocuestaf requested review from richiprosima and removed request for richiprosima February 19, 2026 07:00
@emiliocuestaf emiliocuestaf changed the base branch from master to fast/rpc-refactor February 19, 2026 07:40
@emiliocuestaf emiliocuestaf changed the title Feature/create api extension [24182] DomainParticipant API extension to include return codes Feb 19, 2026
@emiliocuestaf emiliocuestaf changed the title [24182] DomainParticipant API extension to include return codes [24182] Extend DomainParticipant API to include return codes Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments