[24182] Extend DomainParticipant API to include return codes#6314
Open
emiliocuestaf wants to merge 4 commits intofast/rpc-refactorfrom
Open
[24182] Extend DomainParticipant API to include return codes#6314emiliocuestaf wants to merge 4 commits intofast/rpc-refactorfrom
emiliocuestaf wants to merge 4 commits intofast/rpc-refactorfrom
Conversation
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the public API of DomainParticipant.h to include "create_X(..., RetCode_t &ret, ...)" functions, which have the return code as an output argument.
This PR depends on #6308 and must be merged after that one. That PR already extended the API for the RPC-related entities, this is just a continuation of that work. Once it has been merged, please do a git rebase --onto to correctly squash all the commits coming from that PR as done in master.
As a consequence, any reviewer should only review from commit ed8b654 on. I'm sorry for the inconvenience.
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist