Skip to content

Fix ABI compliance#6319

Merged
rsanchez15 merged 2 commits intomasterfrom
bugfix/abi
Feb 26, 2026
Merged

Fix ABI compliance#6319
rsanchez15 merged 2 commits intomasterfrom
bugfix/abi

Conversation

@richiware
Copy link
Member

@richiware richiware commented Feb 25, 2026

Description

Fix ABI compliance

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@emiliocuestaf emiliocuestaf added this to the v3.5.0 - Frozen ❄️ milestone Feb 25, 2026
@github-actions github-actions bot added the ci-pending PR which CI is running label Feb 25, 2026
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware requested review from emiliocuestaf and removed request for emiliocuestaf February 25, 2026 07:48
@mergify
Copy link
Contributor

mergify bot commented Feb 25, 2026

🧪 CI Insights

Here's what we observed from your CI run for c602b46.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View
Fast DDS Ubuntu CI ubuntu-ci / fastdds_test (RelWithDebInfo) Unknown 0 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, examples), v142 Unknown 0 View View
windows-ci / fastdds_test (RelWithDebInfo, examples), v143 Unknown 0 View View

Copy link
Contributor

@emiliocuestaf emiliocuestaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@emiliocuestaf emiliocuestaf added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Feb 25, 2026
@rsanchez15 rsanchez15 merged commit a9160e8 into master Feb 26, 2026
27 of 33 checks passed
@rsanchez15 rsanchez15 deleted the bugfix/abi branch February 26, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants