Added support for SERIAL transport on Windows#349
Open
sebastieninria wants to merge 2 commits intoeProsima:ros2from
Open
Added support for SERIAL transport on Windows#349sebastieninria wants to merge 2 commits intoeProsima:ros2from
sebastieninria wants to merge 2 commits intoeProsima:ros2from
Conversation
sebastieninria
force-pushed
the
pr_serial_windows
branch
from
4255660 to
0f115c4
Compare
Contributor
|
Build status:
|
Signed-off-by: THOMAS Sebastien <sebastien.thomas@inria.fr>
Signed-off-by: THOMAS Sebastien <sebastien.thomas@inria.fr>
sebastieninria
force-pushed
the
pr_serial_windows
branch
from
d51d8b0 to
905d1a9
Compare
Contributor
|
Build status:
|
Contributor
|
Hello @sebastieninria, thanks for the contribution, we currently do not have enough bandwidth for an in-depth review, testing, and adding the required integration tests . I'm gonna fork your branch in order to keep these changes available for the future when we are able to merge it. In any case, thanks a lot for your effort. |
Author
|
No worry, this is something we needed anyway so i had to do this. If if can help someone else, that's cool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a proposal adding support for SERIAL transport on Windows system.
It works well for our needs, i tried to replicate the posix way as much as possible.
It may not be the most perfect nor complete (didn't do anything about multiserial nor pseudoterminal) but it may serve as a good basis for anyone needing that kind of functionality on Windows system (as we did).