Skip to content

Fix wrong use of ret code enumeration in logs #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emiliocuestaf merged 2 commits into from
Jan 2, 2026
Merged

Fix wrong use of ret code enumeration in logs #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60967e1
Fix wrong use of ret code enumeration in logs
emiliocuestaf Jan 2, 2026
e24e3ab
Fix comment
emiliocuestaf Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cpp_utils/include/cpp_utils/ReturnCode.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ class ReturnCode

protected:

//! Link every ReturnCode available with a string to deserialize
static const std::map<ReturnCode, std::string> to_string_conversion_;
//! Link every ReturnCodeValue available with a string to deserialize
static const std::map<ReturnCodeValue, std::string> to_string_conversion_;

//! \c ReturnCode value
std::uint32_t value_;
Expand Down
4 changes: 2 additions & 2 deletions cpp_utils/src/cpp/ReturnCode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ bool ReturnCode::operator !() const noexcept
return value_ != ReturnCode::RETCODE_OK;
}

const std::map<ReturnCode, std::string> ReturnCode::to_string_conversion_ =
const std::map<ReturnCode::ReturnCodeValue, std::string> ReturnCode::to_string_conversion_ =
{
{ReturnCode::RETCODE_OK, "Ok"},
{ReturnCode::RETCODE_ERROR, "Error"},
Expand All @@ -103,7 +103,7 @@ std::ostream& operator <<(
std::ostream& os,
const ReturnCode& code)
{
auto it = ReturnCode::to_string_conversion_.find(code);
auto it = ReturnCode::to_string_conversion_.find(static_cast<ReturnCode::ReturnCodeValue>((code())));
assert(it != ReturnCode::to_string_conversion_.end());
os << "{" << it->second << "}";
return os;
Expand Down