-
Notifications
You must be signed in to change notification settings - Fork 1
fix BackupMultiBucket's need for ExceptionGroup #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
7fb7a81
a2f8251
9f3d04d
e877a5d
fdfe0c0
7b0dab4
2d1a95d
45dc989
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,12 @@ | ||
| import contextlib | ||
| import logging | ||
| import sys | ||
| from pathlib import Path, PurePosixPath | ||
| from typing import BinaryIO, Iterable | ||
|
|
||
| from exceptiongroup import ExceptionGroup | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @amaximciuc |
||
| if sys.version_info < (3, 11): | ||
| from exceptiongroup import ExceptionGroup | ||
|
|
||
| from streamerate import slist, sset | ||
| from typing_extensions import override | ||
|
|
||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| # mypy: disable-error-code="no-untyped-def" | ||
| import gc | ||
| import os | ||
| import sys | ||
| import tempfile | ||
| import threading | ||
| from io import BytesIO | ||
|
|
@@ -9,7 +10,9 @@ | |
| from unittest import TestCase | ||
|
|
||
| import psutil | ||
| from exceptiongroup import ExceptionGroup | ||
| if sys.version_info < (3, 11): | ||
|
||
| from exceptiongroup import ExceptionGroup | ||
|
Comment on lines
+13
to
+16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial More idiomatic approach: simplify the ExceptionGroup check. The current pattern Option 1 (simpler try-except): -try:
- _ = ExceptionGroup.__class__
-except NameError:
+try:
+ ExceptionGroup
+except NameError:
from exceptiongroup import ExceptionGroupOption 2 (version check – most explicit): import sys
if sys.version_info < (3, 11):
from exceptiongroup import ExceptionGroupBased on learnings: Previous review requested try-except approach, which has been implemented. 🤖 Prompt for AI Agents |
||
|
|
||
| from minio import Minio | ||
|
|
||
| from bucketbase import MemoryBucket, MinioBucket, ShallowListing | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing
--no-updateflag as stated in the PR description.The PR description explicitly mentions running
poetry lock --no-update, but the workflow just runspoetry lock. Without the--no-updateflag, Poetry will upgrade all dependencies to their latest compatible versions, which could introduce unexpected changes in CI. This is probably not what you want for reproducible builds.Apply this diff:
📝 Committable suggestion
🤖 Prompt for AI Agents