Metadata validation service now validates against five-safes-crate profile.#130
Open
Metadata validation service now validates against five-safes-crate profile.#130
Conversation
|
kinda hard to see the logical changes with the linting being applied too... is this the key change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #129
Issue
When passing
profile_name="five-safes-crate"to the endpoint/validate_metadata, the validation failed to run and the following message was returned "Profile not found: five-safes-crate".The reason for this was that
profiles_pathwas passed in the wrong argument position when callingperform_metadata_validationfromprocess_validation_task_by_metadata. In particular, the call was made like this:perform_metadata_validation(crate_json, profile_name, profiles_path)but in that function signature, the third argument is
skip_checks_list, notprofiles_path. Consequentlyprofiles_pathwas ignored, and validation fell back to the default profile location:/usr/local/lib/python3.11/site-packages/rocrate_validator/profilesFix
profiles_pathis now passed explicitly as a keyword:perform_metadata_validation(crate_json, profile_name, profiles_path=profiles_path)Result
Metadata validation now uses the configured non-default path from
PROFILES_PATH(in dev compose:/app/profiles) instead of the package default, so five-safes-crate resolves correctly.Regression assertions were added in
test_validation_tasks.pyto reflect this new behaviour.