Skip to content

Update main.yml to fix HBV#176

Merged
MarkMelotto merged 2 commits intomainfrom
fix-prep_shared_data-hbv
Mar 11, 2025
Merged

Update main.yml to fix HBV#176
MarkMelotto merged 2 commits intomainfrom
fix-prep_shared_data-hbv

Conversation

@MarkMelotto
Copy link
Contributor

updated file to incorporate the eWC version of HBV

@sverhoeven please check if the second line, so apptainer, is correct.
I am pretty sure the docker: is correct

updated file to incorporate the eWC version of HBV
@MarkMelotto MarkMelotto requested a review from sverhoeven March 11, 2025 12:32
Comment on lines 26 to 27
- docker: ghcr.io/ewatercycle/hbv-bmi-grpc4bmi:v1.5.2
apptainer: ewatercycle-hbv-bmi-grpc4bmi_v1.5.2.sif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On https://github.com/eWaterCycle/HBV-bmi/pkgs/container/hbv-bmi-grpc4bmi I only see latest version

Suggested change
- docker: ghcr.io/ewatercycle/hbv-bmi-grpc4bmi:v1.5.2
apptainer: ewatercycle-hbv-bmi-grpc4bmi_v1.5.2.sif
- docker: ghcr.io/ewatercycle/hbv-bmi-grpc4bmi:latest
apptainer: ewatercycle-hbv-bmi-grpc4bmi_v1.5.2.sif

or

docker tag ghcr.io/ewatercycle/hbv-bmi-grpc4bmi:latest ghcr.io/ewatercycle/hbv-bmi-grpc4bmi:v.1.5.2
docker push ghcr.io/ewatercycle/hbv-bmi-grpc4bmi:v.1.5.2

Copy link
Member

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should work

@MarkMelotto MarkMelotto merged commit 219dcdb into main Mar 11, 2025
1 check passed
@MarkMelotto MarkMelotto deleted the fix-prep_shared_data-hbv branch March 11, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants