Skip to content
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions roles/ewatercycle/templates/environment.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ dependencies:
# Conda version of papermill is not py3.12 compat, so use pip version
- papermill==2.6.0
- rich==13.9.4
- folium==0.20.0
- geopandas==1.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be better to put these in the conda dependencies, not pip. That would reduce the chance of environment conflicts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is then in the conda-lock file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no just slightly lower in this same file. Below the # Jupyter comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahaa thanks!

# Pangeo deps, see https://pangeo.io/setup_guides/hpc.html
# TODO add pangeo deps back?

Expand Down