Skip to content

Refactor view module #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2025
Merged

Refactor view module #1086

merged 3 commits into from
Apr 10, 2025

Conversation

@line-o
Copy link
Member

@line-o line-o commented Apr 9, 2025 •
edited
Loading

Depend on upcoming templating v1.2.0 and make use of its new capabilities.

  • Rendered HTML will no longer be cluttered with data-template attributes.
  • Legacy class-syntax for templates is no longer allowed
  • various smaller improvements

@line-o line-o force-pushed the deps/templating branch from 2731aee to 62035a5 Compare April 9, 2025 17:12
@line-o
[enhancement] improve view module
538f479 
- refactor for readability
- make use of newer templating features
  - filter templating attributes from rendered HTML
  - disallow legacy class-syntax
- remove unnecessary try-catch from lookup function which is now named, too
@line-o line-o changed the title [ignore] bump templating to 1.2.0 Refactor view module Apr 9, 2025
@line-o line-o requested review from a team April 9, 2025 17:39
@line-o
Copy link
Member Author

line-o commented Apr 9, 2025

Turns out that templating v1.2.0 had to be published to public-repo first. This is done now.

duncdrum
duncdrum requested changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the failing search test

@line-o
Copy link
Member Author

line-o commented Apr 10, 2025

See this is why we have tests:

<input class="form-control templates:form-control" ...>

must now be

<input class="form-control" data-template="templates:form-control" ...>

@line-o line-o requested a review from duncdrum April 10, 2025 00:31
duncdrum
duncdrum approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @line-o looking good now.

@duncdrum duncdrum merged commit 0d7f107 into eXist-db:master Apr 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duncdrum duncdrum duncdrum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@line-o @duncdrum