feature frontend dependencies #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
duncdrum
force-pushed
the
frontend-plugin
branch
from
1454c76 to
1e05955
Compare
dizzzz
reviewed
Dec 31, 2018
dizzzz
reviewed
Dec 31, 2018
fix(review): bump semver in packag.json from pom.xml
adamretter
reviewed
Jan 2, 2019
| @@ -0,0 +1,2469 @@ | |||
| { | |||
There was a problem hiding this comment.
Shouldn't package-lock.json be in the .gitignore?
There was a problem hiding this comment.
Then I 'd like to restate my concern with the double definition of the same version configuration ...
|
@duncdrum Happy to help with the XQSuite tests, do you have some tests? |
adamretter
approved these changes
Jan 2, 2019
|
@adamretter they are in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR removes most (ace is a nightmare and on its way out see #141) frontend dependencies on shared-resources, and incorporates tracking and building js dependencies via maven.
This goes along with a minor version upgrade to bootstrap and jQuery ootb. This is to facilitate further work on the redesign of the documentation app (and taking shared-resources out of the loop as much as possible for now).
@adamretter please take a look at the js tests, and let me know if there is anything i can do to add the xqsuite tests in a similar manner.