Skip to content

Springcleaning 2020 #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Feb 2, 2020
Merged

Springcleaning 2020 #432

merged 34 commits into from
Feb 2, 2020

Conversation

duncdrum
Copy link
Contributor

smokey says: "only you can prevent the docs from getting out of date"

duncdrum added 15 commits January 27, 2020 00:07
@duncdrum
ignore(package): release fallout
74e42de
@duncdrum
feat(page): add issue report button
0a4689c 
close #34
@duncdrum
fix(lucene): add info about diacritics analyzer
fa0503f 
close #83
@duncdrum
fix(lucene): add info about diacritics analyzer
23895a8 
close #83
@duncdrum
Merge branch 'springcleaning-2020' of https://github.com/duncdrum/doc…
3e8a263 
…umentation into springcleaning-2020
@duncdrum
fix(page): breadcrumbs
c212b6d 
close #32
@duncdrum
docs(readme): remove WIP note about unit tests
fe71c09 
they are fully working
@duncdrum
fix(urlrewrite): metion missing errorhandler element
e68d2b1 
close #105
@duncdrum
ci(cypress): adjust test
c70ba1d
@duncdrum
fix(webdav): rewrite and outdated info
012e96b 
@dizzzz 
close eXist-db#201
@duncdrum
fix(log4j): start rewrite of log4j
ee4c8e4 
see eXist-db#230
@duncdrum
fix(log4j): continue rewrite
bd8539e 
see eXist-db#230
@duncdrum
fix(xsl-transform): add -it and catalog info
7db2b52 
close eXist-db#234
@duncdrum
fix(xqsuite): add assertEqualsPermutation
cc3e07d 
@wolfgangmm please review
close eXist-db#241
@duncdrum
feature(docker): start adding docker docs
d8a6c63 
see eXist-db#248
@duncdrum duncdrum requested a review from a team January 28, 2020 01:33
lguariento
lguariento approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@lguariento lguariento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

tuurma
tuurma approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@tuurma tuurma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stylistic comments, otherwise good to go.

One side note for the future, it would simplify review greatly to keep the prettyfing changes (like whitespace) in a separate PR to make review easier. Many thanks though for the springcleaning effort!

joewiz and others added 11 commits January 28, 2020 12:06
@joewiz
Correct XQSuite punctuation
13c4e14 
See https://exist-db.org/exist/apps/doc/xqsuite
@duncdrum
feature(docker): finish docker docs
dc7cb3b 
close eXist-db#248
@duncdrum
Merge branch 'springcleaning-2020' of https://github.com/duncdrum/doc…
50775f9 
…umentation into springcleaning-2020
@duncdrum
fix(page): remove broken status link
2b357af
@duncdrum
fix(page): add version popover to breadcrumbs home
0fd051c 
close #157
@duncdrum
fix(xar-assembly): workaround namespace confusion in xar builder
89d3317 
close eXist-db#433
@duncdrum
fix(lucene): add ranged query
d07ffc6 
close eXist-db#323
@duncdrum
fix(prod_web_prox): add warning about poor default configs
1813edf 
close eXist-db#264
@duncdrum
feat(gulp): lint xml listings
6f16656 
close eXist-db#431
@duncdrum
ignore(listings): have been linted
09c39d6
@duncdrum
fix(gulp): switch xml lint library
8988ba6 
see eXist-db#431
@duncdrum duncdrum force-pushed the springcleaning-2020 branch from ea06b1a to 290af25 Compare January 29, 2020 12:29
@duncdrum duncdrum marked this pull request as ready for review January 29, 2020 20:59
@duncdrum
Copy link
Contributor Author

Thank you for the speedy reviews, while i was still working on this. I have incorporated your comments.

@joewiz schematron is not available for now, if we need to extend the new schema rules beyond the abilities of relaxng we should do so via the test-suite.xql.

@tuurma yes while you can choose not to display whitespace changes in the review options on Github, this is what it is. We are now linting all listings during build, we could extend that to articles, which would make review easier, but last time i suggested that there was some pushback. So maybe something for the community call.

mic drop

@duncdrum duncdrum added this to the 5.2.0 milestone Jan 29, 2020
@duncdrum duncdrum requested a review from a team January 29, 2020 23:17
@duncdrum duncdrum force-pushed the springcleaning-2020 branch from 8624887 to 63b2a4b Compare January 30, 2020 22:26
@duncdrum duncdrum merged commit 739095a into eXist-db:master Feb 2, 2020
@duncdrum duncdrum deleted the springcleaning-2020 branch February 2, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuurma tuurma tuurma approved these changes

@lguariento lguariento lguariento approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@duncdrum @tuurma @lguariento @joewiz