Make exist-xqts runner compatible with 7.0.0-SNAPSHOT of exist-db #38
Conversation
line-o
force-pushed
the
7-compat
branch
2 times, most recently
from
821a78f to
cadd44d
Compare
|
for compilation to work again we need to point the build process to a more recent version of exist v7.0.0-SNAPSHOT |
@line-o There are different versions of xqts-runner that target 6.x.x and various 7.x.x - you just need to choose the right version. You can find the version of eXist-db supported by looking in the build.sbt of the various versions of xqts-runner |
|
@adamretter I tried all published versions 1.3.0-SNAPSHOT, 1.3.0 and 1.4.0 none of them worked. This branch built against a current develop head does. |
|
@line-o I am afraid you looked in the wrong place. If you want 7.0.0-SNAPSHOT compatibility it has been here for years - https://github.com/eXist-db/exist-xqts-runner/tree/compat/eXist-7.0.0-SNAPSHOT |
|
Now that this finally passed the smoke test again a little cleanup is needed before it can be marked as ready. |
BREAKING CHANGE: build target is now Java21
* mark exist-core dependency as "changing" to enforce SNAPSHOT updates * update slf4j and log4j-slf4j2-impl to the same version that exist uses at the moment * update akka-actor to 2.8.1-M1 to fix a vulnerability * update all other dependencies to the latest non-breaking update
Dependencies like exist-core are published to the github maven repository. It does _require_ authentication. For this to work a Github personal access token needs to be set. This can be done in either `~/.ivy2/.credentials` or setting the environment variable "GITHUB_TOKEN" (used in the github action).
There was a problem hiding this comment.
This targets the wrong branch, and is redundant as the work was already done years ago and can be found in the branch https://github.com/eXist-db/exist-xqts-runner/tree/compat/eXist-7.0.0-SNAPSHOT. In addition this project is redundant entirely as it has been replaced by XTH.
|
|
||
| ```scala | ||
| val existV = "5.3.0" | ||
| val existV = "7.0.0-SNAPSHOT" |
There was a problem hiding this comment.
This won't work in production as snapshots are not permitted
There was a problem hiding this comment.
I do not understand why this cannot be written in the readme. Should there be an additional sentence? To which production are you referring to?
|
@adamretter out of curiosity, what is XTH? |
@line-o XTH = X Test Harness. It replaced this some time ago. |
|
Do you have a link perhaps? @adamretter I cannot find any information on that. |
This PR is built on top of the other branch and supersedes it. It targets |
That is not how this project is setup or structured. |
I am not sure what you mean by this. If you want to suggest a way forward please do so, otherwise I would like to continue with the current plan. |
|
PR looks solid to me; as stated we can correctly run the suite now, that is what counts in the end. |
The project was setup to have two branches - one for eXist-db and Elemental 6.x.x, and the other one for 7.x.x |
|
It will still be that way. Just a slightly different approach:
Please Note: Because tests are run against a version of existdb we only guarantee compatibility with this processor |
|
@line-o Understood, but switching the main branch doesn't make sense until there is a release of eXist-db 7.0.0 as otherwise it cannot be used in production. |
|
For me main is the branch I expect to get the current latest state from. |
For me, what comes from |
This is a breaking change as older versions of exist-db cannot use this xqts-runner anymore