[refactor] Made SonarCloud recommended changes.

chris-evolvedbinary · chris-evolvedbinary · commit 4e52f37ebd26 · 2022-06-30T08:34:43.000-06:00
diff --git a/exist-core/src/main/java/org/exist/xquery/value/DoubleValue.java b/exist-core/src/main/java/org/exist/xquery/value/DoubleValue.java
@@ -224,7 +224,7 @@ public AtomicValue convertTo(final int requiredType) throws XPathException {
                 if (requiredType != Type.INTEGER && value > Integer.MAX_VALUE) {
                     throw new XPathException(getExpression(), ErrorCodes.FOCA0003, "Value is out of range for type " + Type.getTypeName(requiredType));
                 }
-                return new IntegerValue(getExpression(), new Double(value).longValue(), requiredType);
+                return new IntegerValue(getExpression(), (long) value, requiredType);
             case Type.BOOLEAN:
                 return new BooleanValue(getExpression(), this.effectiveBooleanValue());
             default:

Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,7 @@ public AtomicValue convertTo(final int requiredType) throws XPathException {`
`224`	`224`	`if (requiredType != Type.INTEGER && value > Integer.MAX_VALUE) {`
`225`	`225`	`throw new XPathException(getExpression(), ErrorCodes.FOCA0003, "Value is out of range for type " + Type.getTypeName(requiredType));`
`226`	`226`	`}`
`227`		`- return new IntegerValue(getExpression(), new Double(value).longValue(), requiredType);`
	`227`	`+ return new IntegerValue(getExpression(), (long) value, requiredType);`
`228`	`228`	`case Type.BOOLEAN:`
`229`	`229`	`return new BooleanValue(getExpression(), this.effectiveBooleanValue());`
`230`	`230`	`default:`