Skip to content

Commit fbedb1d

Browse files
committed
[fix] Deployment handles dependency elements properly
When handling dependency elements in package descriptor files the package version attribute was checked in order to determine if a specific dependency version was pinned for this dependency. Now that the DOM implementation will always return an empty string instead of null for unset attributes this now means that 1. the package version is set (otherwise the package would not install) 2. the version variable for each dependency will be non-null because the package version is set. The type will then vary on the attribute value - this would have been null in the past and is now an empty string which changes the resulting DependemcyVersion subtype.
1 parent fe59d2a commit fbedb1d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

exist-core/src/main/java/org/exist/repo/Deployment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ public Optional<String> installAndDeploy(final DBBroker broker, final Txn transa
207207
version = new PackageLoader.Version(semVer, true);
208208
} else if (!semVerMax.isEmpty() || !semVerMin.isEmpty()) {
209209
version = new PackageLoader.Version(semVerMin.isEmpty() ? null: semVerMin, semVerMax.isEmpty() ? null: semVerMax);
210-
} else if (!pkgVersion.isEmpty()) {
210+
} else if (!versionStr.isEmpty()) {
211211
version = new PackageLoader.Version(versionStr, false);
212212
}
213213

0 commit comments

Comments
 (0)