[refactor] Use new ByteConversion APIs

Author: dizzzz

extensions/indexes/lucene/src/main/java/org/exist/indexing/lucene/LuceneUtil.java

@@ -72,7 +72,7 @@ public static byte[] createId(final NodeId nodeId) {
 
     public static NodeId readNodeId(final int doc, final BinaryDocValues nodeIdValues, final BrokerPool pool) {
         final BytesRef ref = nodeIdValues.get(doc);
-        final int units = ByteConversion.byteToShort(ref.bytes, ref.offset);
+        final int units = ByteConversion.byteToShortH(ref.bytes, ref.offset);
         return pool.getNodeFactory().createFromData(units, ref.bytes, ref.offset + 2);
     }
 

extensions/indexes/range/src/main/java/org/exist/indexing/range/RangeIndexWorker.java

@@ -468,7 +468,7 @@ private void write() {
                 // store the node id
                 int nodeIdLen = pending.getNodeId().size();
                 byte[] data = new byte[nodeIdLen + 2];
-                ByteConversion.shortToByte((short) pending.getNodeId().units(), data, 0);
+                ByteConversion.shortToByteH((short) pending.getNodeId().units(), data, 0);
                 pending.getNodeId().serialize(data, 2);
                 fNodeId.setBytesValue(data);
                 doc.add(fNodeId);
@@ -633,8 +633,8 @@ public void collect(int doc) throws IOException {
             }
             final BytesRef ref = this.nodeIdValues.get(doc);
 
-            int units = ByteConversion.byteToShort(ref.bytes, ref.offset);
-            NodeId nodeId = index.getBrokerPool().getNodeFactory().createFromData(units, ref.bytes, ref.offset + 2);
+            final int units = ByteConversion.byteToShortH(ref.bytes, ref.offset);
+            final NodeId nodeId = index.getBrokerPool().getNodeFactory().createFromData(units, ref.bytes, ref.offset + 2);
 
             // if a context set is specified, we can directly check if the
             // matching node is a descendant of one of the nodes
@@ -1019,7 +1019,7 @@ private void scan(DocumentSet docs, NodeSet nodes, String start, String end, lon
                         NodeId nodeId = null;
                         if (nodes != null) {
                             final BytesRef nodeIdRef = nodeIdValues.get(docsEnum.docID());
-                            int units = ByteConversion.byteToShort(nodeIdRef.bytes, nodeIdRef.offset);
+                            final int units = ByteConversion.byteToShortH(nodeIdRef.bytes, nodeIdRef.offset);
                             nodeId = index.getBrokerPool().getNodeFactory().createFromData(units, nodeIdRef.bytes, nodeIdRef.offset + 2);
                         }
                         if (nodeId == null || nodes.get(storedDocument, nodeId) != null) {