Skip to content

(5.0.0) Improve classpath modules resolution #2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2019
Merged

(5.0.0) Improve classpath modules resolution #2361

merged 2 commits into from
Jan 5, 2019

Conversation

adamretter
Copy link
Contributor

Backport of #2360

@adamretter adamretter added the bug issue confirmed as bug label Jan 3, 2019
@adamretter adamretter added this to the eXist-5.0.0-RC6 milestone Jan 3, 2019
@adamretter adamretter requested review from dizzzz and duncdrum January 3, 2019 03:59
dizzzz
dizzzz requested changes Jan 3, 2019
View reviewed changes
Copy link
Member

@dizzzz dizzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have a potential security concern....

duncdrum
duncdrum approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Win CI is happy, I ll leave @dizzzz to judge and merge in case there is indeed a security problem that is above my pay grade

@dizzzz dizzzz merged commit 99eeb9c into eXist-db:develop-5.0.0 Jan 5, 2019
@adamretter adamretter deleted the module-classpath-relative-5.0.0 branch January 5, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizzzz dizzzz dizzzz requested changes

@duncdrum duncdrum duncdrum approved these changes

Assignees
No one assigned
Labels
bug issue confirmed as bug
Projects
None yet
Milestone
eXist-5.0.0-RC6
Development

Successfully merging this pull request may close these issues.
3 participants
@adamretter @dizzzz @duncdrum