Fix Java issues on eXist-db 6.x.x #87

adamretter · 2025-06-23T17:08:58Z

The Java code previously did not compile against eXist-db 6.x.x. This PR fixes that.
Once we have 6.x.x working again, we would hope for a release of the Crypto module. After that we will backport code from our fork for Elemental to get this also working against eXist-db 7.0.0-SNAPSHOT, and then another release could be made...

NOTE - This first requires a version 2.0.0 of exist-apps-parent to be produced by merging the PR - eXist-db/exist-apps-parent#93 and creating a release of it.

For the first time in a very long time (3+ years?), now all of the tests pass 100% :-)

Closes #64
Closes #86

Additionally:
Closes #88
Closes #85
Closes #84
Closes #83
Closes #82
Closes #81
Closes #80
Closes #79
Closes #78
Closes #77

adamretter · 2025-06-23T20:11:50Z

@reinhapa I also took care of CI in here too.

line-o

This PR changes the parent POM to

  <groupId>xyz.elemental.expath</groupId>
  <artifactId>elemental-expath-package-parent</artifactId>
  <version>1.0.0</version>

Where can this new "dependency" be reviewed?

adamretter · 2025-06-24T07:23:52Z

This PR changes the parent POM

@line-o Yes, unfortunately there are quite a few issues with the previous parent that was used (https://github.com/exist-db/exist-apps-parent). So I started from scratch and created the more modern elemental-expath-package-parent to address those issues.

Where can this new "dependency" be reviewed?

@line-o Same place as all the others:

Assuming you have run the PR code, (if I recall correctly, you use macOS?), that would be: ~/.m2/repository/xyz/elemental/expath/elemental-expath-package-parent/1.0.0/elemental-expath-package-parent-1.0.0.pom on your computer
Otherwise if you haven't run it yet, then the same place as all other good Open Source Maven dependencies, Maven Central - https://central.sonatype.com/artifact/xyz.elemental.expath/elemental-expath-package-parent

line-o · 2025-06-24T07:35:37Z

here is the GitHub link https://www.github.com/evolvedbinary/elemental-expath-package-parent

I am strongly in favour of fixing / changing the exist-db apps parent POM for packages hosted here. But I do know of at least one really big issue: It declares OSS-sonatype as its parent POM.
While the expath-package-parent does not do that it still wants to publish jars to Maven central it seems.

adamretter · 2025-06-24T07:56:08Z

the exist-db apps parent POM for packages hosted here. But I do know of at least one really big issue: It declares OSS-sonatype as its parent POM

@line-o That is just one of several problems in there. Honestly, it was easier to just start again. There is nothing Elemental specific in the elemental-expath-package-parent so it would be easiest for you to just switch to that, as it is maintained and fixes the issue with the older elemental-expath-package-parent. We put it under the Apache 2.0 license so that it can be used by anyone.

While the expath-package-parent does not do that

@line-o Nobody should be doing that any more as the oss-parent has been deprecated now for many years and is unmaintained.

it still wants to publish jars to Maven central it seems.

@line-o Yes, that is where almost all Open Source jar files are published. It is where developers expect to find libraries and is the default in the JVM ecosystem. It is also where all of the eXist-db releases have been published since 5.x.x. What is the problem?
If you have some closed source projects you want to publish elsewhere to some private repo it is trivial to override that behaviour in your own pom.xml that inherits from elemental-expath-package-parent.

reinhapa · 2025-06-28T15:42:33Z

@adamretter @line-o why do we need a parent POM in the first place? I think this introduces unnecessary coupling. I see that only in a multi-module scenario within the same repository.

adamretter · 2025-06-28T18:51:52Z

why do we need a parent POM in the first place

@reinhapa Yes. Without it you end up copying and pasting a lot of config into each individual project's pom.xml file, which then over time become out of sync with each other and you have an even larger mess to maintain.

aljopainter

Quite a few changes that look good and simplify things. Tests working. Thanks.

adamretter · 2025-06-30T12:30:54Z

Thanks @aljopainter for your review and kind feedback :-)

marmoure

LGTM :) Tests are passing locally and on CI, the build is working.
Thanks @adamretter

reinhapa · 2025-07-14T17:52:06Z

README.md

The change of this file seems unrelated to the Java issues...

@reinhapa it is related to the packaging, assembly, and test changes. It simply reflects that the module now works on eXist-db and Elemental. Where do you see an issue please?

@adamretter I see mainly the addition of Elemental, except to be the reference to the version >= 6.0.0 for eXist-db (and in this case may be Elemental with the same version)

I appreciate your work, but those changes, are one of those things, that will make me hesitate to approve. Or would you allow eXist-db reference additions on Elemental in one of your repositories?

@reinhapa Thanks :-) I'm not sure if I understand your question/concern or not though. This PR has two concerns:

Fix the module and make it work correctly with eXist-db 6 (including passing CI)

Add a minimal processor declaration to the XAR descriptor so that it also works with Elemental.

Adding the processor declaration for Elemental means that this App supports both eXist-db and Elemental.
This is intentional, as I don't think it makes sense for Elemental to fork all of the eXst-db Apps. IMHO, it makes more sense where possible to have a single code base for an App that benefits from improvements by both eXist-db and Elemental developers contributing to it.

would you allow eXist-db reference additions on Elemental in one of your repositories

If we had a repo that contains an App or Library that is compatible with Elemental and eXist-db, then we would be happy for it to also contain a processor declaration for eXist-db and have that mentioned in the README.md.

I'm not sure if that answers your question/concern? If not, let me know and we can go from there...

line-o · 2025-07-21T18:49:37Z

src/test/xquery/crypto/crypto-tests.xqm

 declare
    %test:name("Hash binary with wrong algorithm, default format")
-    %test:assertError("err:CX21: The algorithm is not supported.")
+    %test:assertError("crypto:unknown-algorithm")


The error code that is raised is changed looking at the test. This would constitute a breaking change.

It's likely not the only change. The release of this will need to bump the major version number.

line-o · 2025-07-21T18:50:30Z

src/test/xquery/crypto/crypto-tests.xqm

 declare
    %test:name("Validate enveloped digital signature")
    %test:assertTrue
+    %test:pending("Need to find a way to load the keystore.ks correctly from the filesystem")


To my understanding this test did pass in earlier versions. What changed so this test has to be skipped?

Have you looked in detail at what this was actually testing previously?

…ignature() was not compatible with eXist-db 6.0.0 or newer Closes eXist-db#64

…ation See eXist-db#41

reinhapa · 2025-07-15T06:01:08Z

README.md

@adamretter I see mainly the addition of Elemental, except to be the reference to the version >= 6.0.0 for eXist-db (and in this case may be Elemental with the same version)

I appreciate your work, but those changes, are one of those things, that will make me hesitate to approve. Or would you allow eXist-db reference additions on Elemental in one of your repositories?

adamretter force-pushed the feature/6.x.x-elemental-existdb-compatibility branch 3 times, most recently from 950fb46 to 1b5325f Compare June 23, 2025 20:07

adamretter marked this pull request as ready for review June 23, 2025 20:11

line-o reviewed Jun 24, 2025

View reviewed changes

adamretter mentioned this pull request Jun 24, 2025

Investigate which spec this package implements and identify deviations #41

Open

3 tasks

adamretter force-pushed the feature/6.x.x-elemental-existdb-compatibility branch from 1b5325f to 5dee06b Compare June 24, 2025 07:39

adamretter mentioned this pull request Jun 24, 2025

Bump org.expath.crypto:crypto-java from 1.8.0 to 1.9.0 #88

Open

adamretter mentioned this pull request Jun 25, 2025

[feature] crypto library implementation compatible with exist 7 eXist-db/exist#5770

Open

adamretter requested a review from line-o June 25, 2025 15:58

adamretter mentioned this pull request Jun 26, 2025

Make Monex compatible with eXist-db 6.x.x and 7.x.x eXist-db/monex#298

Open

aljopainter approved these changes Jun 30, 2025

View reviewed changes

marmoure approved these changes Jul 2, 2025

View reviewed changes

adamretter force-pushed the feature/6.x.x-elemental-existdb-compatibility branch from 5dee06b to 5088012 Compare July 11, 2025 11:11

reinhapa requested changes Jul 14, 2025

View reviewed changes

line-o reviewed Jul 21, 2025

View reviewed changes

adamretter added 3 commits July 28, 2025 19:17

Update for eXist-db and Elemental 6.x.x, previously crypto:generate-s…

29f299a

…ignature() was not compatible with eXist-db 6.0.0 or newer Closes eXist-db#64

Fix failing tests

a391f52

Correct the function signatures so they follow the spec and implement…

18391e7

…ation See eXist-db#41

adamretter force-pushed the feature/6.x.x-elemental-existdb-compatibility branch from 5088012 to 18391e7 Compare July 28, 2025 17:17

reinhapa approved these changes Jul 28, 2025

View reviewed changes

Uh oh!

Fix Java issues on eXist-db 6.x.x #87

Are you sure you want to change the base?

Fix Java issues on eXist-db 6.x.x #87

Uh oh!

Conversation

adamretter commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adamretter commented Jun 23, 2025

Uh oh!

line-o left a comment

Choose a reason for hiding this comment

Uh oh!

adamretter commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

line-o commented Jun 24, 2025

Uh oh!

adamretter commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reinhapa commented Jun 28, 2025

Uh oh!

adamretter commented Jun 28, 2025

Uh oh!

aljopainter left a comment

Choose a reason for hiding this comment

Uh oh!

adamretter commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marmoure left a comment

Choose a reason for hiding this comment

Uh oh!

reinhapa Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

adamretter Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

reinhapa Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

adamretter Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

line-o Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

adamretter Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

line-o Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

adamretter Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

reinhapa Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

adamretter commented Jun 23, 2025 •

edited

Loading

adamretter commented Jun 24, 2025 •

edited

Loading

adamretter commented Jun 24, 2025 •

edited

Loading

adamretter commented Jun 30, 2025 •

edited

Loading

adamretter Jul 15, 2025 •

edited

Loading

adamretter Jul 29, 2025 •

edited

Loading