Remove unnecessary type cast #66
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@joewiz Is this ready to be reviewed now? |
Member
Author
|
@line-o While eXist-db/templating#24 was merged, a new release including it hasn't yet been published. Perhaps we should cut one - which I think would be v1.1.1? |
line-o
approved these changes
Apr 9, 2025
Member
line-o
left a comment
line-o
left a comment
There was a problem hiding this comment.
I am confident this is safe to pull in
Member
Author
|
@line-o Sounds good ;) |
line-o
force-pushed
the
remove-unnecessary-type-cast
branch
from
20a93b6 to
9f378ec
Compare
Member
|
@joewiz I just now realised that it was me who introduced the unnecessary cast to boolean... That is so strange. I am starting to lean towards this being a bug in exist-db (at least an incompatability between v6 and v7) |
Merged
duncdrum
added a commit
that referenced
this pull request
Apr 13, 2025
1.1.0 doesn't run properly on 7 and up see #66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until eXist-db/templating#24 is merged and published in a new release of the templating package.See https://github.com/eXist-db/function-documentation/pull/64/files#r1193024584.