Improve application layout and rendering #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@line-o I think we need some tests in the templating repo that capture the different behavior we see between 6 and 7 here, especially regarding checks and forms. The markdown element being swallowed on 7 is a head scratcher. |
Member
Author
|
As we saw yesterday the changes while working fine in exist v6 leads to a NPE in exist v7 |
Member
Author
|
Member
Author
Only exist v7.0.0-SNAPSHOT is affected see eXist-db/exist#5707
Member
Author
|
@duncdrum I found a workaround |
duncdrum
reviewed
Apr 16, 2025
- restructure library imports: external then internal - standards compliant output declaration - lookup without try-catch - disallow legacy class-syntax - filter data-template attributes
joewiz
reviewed
Apr 16, 2025
By switching the form method to get the url will now have all paramters necessary in order to share the search results. The search works as before including the Example: Entering "file:" in the search box and hitting the "Search" button - URL Before http://localhost:8080/exist/apps/fundocs/index.html? - URL After http://localhost:8080/exist/apps/fundocs/index.html?q=file%3A&action=search&type=name
Setting ouput:indent to "no" only works for constructed nodes at the moment. This still lowers the gzipped load by around 10% on results pages.
duncdrum
approved these changes
Apr 22, 2025
Contributor
duncdrum
left a comment
duncdrum
left a comment
There was a problem hiding this comment.
looking good I added a test assertion for the new URLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collection of xqdoc elements now in $app:data
refactor for readability (invert conditions, extract complex tests into functions, ...)
fix formatting
fix styling re-using the SASS files from eXist-db/documentation
[BUG] NPE when running XQuery because "contextSequence" is null exist#5707 (workaround)
closes #71