Conversation
janLo
left a comment
janLo
left a comment
There was a problem hiding this comment.
Generally ok, just a few things that should be changed before merge.
| sure that your database is within that path. | ||
|
|
||
| $ docker run -v <my-cfg>:/config.yaml -v <data-dir>:/data <image-name> | ||
| $ git clone https://github.com/janLo/meet-and-eat-registration-system.git |
There was a problem hiding this comment.
I would seperate this, as it has nothing to do with the actual docker deployment
| $ docker run -v <my-cfg>:/config.yaml -v <data-dir>:/data <image-name> | ||
| $ git clone https://github.com/janLo/meet-and-eat-registration-system.git | ||
| $ cd meet-and-eat-registration-system | ||
| $ docker build . -t <image-name> |
There was a problem hiding this comment.
Give here the alternatives:
- Build the image yourself.
- Pull the image from the docker hub.
| $ git clone https://github.com/janLo/meet-and-eat-registration-system.git | ||
| $ cd meet-and-eat-registration-system | ||
| $ docker build . -t <image-name> | ||
| $ docker run -v <my-cfg>:/config.yaml -v <data-dir>:/data -p 8080:8080 <image-name> |
There was a problem hiding this comment.
Change -p 8080:8080 to [<hostaddress>]:<hostport>:8080, as the first one is the special case where you publish the port on 8080 on any address of your host system. This is not what you want in production.
|
|
||
| Now try to access the Websites: | ||
|
|
||
| localhost:8080/ |
There was a problem hiding this comment.
If you really want to give this, then exchange localhost:8080 and 127.0.0.1:8080 with <hostaddress>:<hostport>:8080 and either give a full list of all accessible endpoints or remove /admin/login, as /admin redirects to that.
| # Format: "yyyy-mm-dd HH:MM" | ||
| REGISTER_END: "2020-05-01 22:30" | ||
| MAX_TEAMS: 51 | ||
| VOLUME: 11 |
There was a problem hiding this comment.
Not sure if we have to change this in the example but ok.
2 participants
No description provided.