use f32 for note coordinates#6
Merged
eadgbear merged 1 commit intoeadgbear:mainfrom Mar 23, 2025
icewind1991:note-resource-f32
Merged
use f32 for note coordinates#6eadgbear merged 1 commit intoeadgbear:mainfrom icewind1991:note-resource-f32
eadgbear merged 1 commit intoeadgbear:mainfrom
icewind1991:note-resource-f32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without floats you can't make notes that don't span the whole post...
This did introduce the need to implement
PartialEq/Eqmanually in order to use total ordering to compare the floats. Just removingEqfromNoteResourceand all types containing it would also be an option but I went with the more minimal change.Additionally it probably makes sense to use
Vec<[f32; 2]>instead ofVec<Vec<f32>>