Skip to content

fix: Permission execution time #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eadwinCode merged 2 commits into from
Dec 4, 2024
Merged

fix: Permission execution time #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d58fabc
fixed authentication run before permission execution
eadwinCode Dec 4, 2024
c31f390
0.21.7
eadwinCode Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ninja_extra/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""Django Ninja Extra - Class Based Utility and more for Django Ninja(Fast Django REST framework)"""

__version__ = "0.21.6"
__version__ = "0.21.7"

import django

Expand Down
16 changes: 8 additions & 8 deletions ninja_extra/operation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,14 +197,14 @@ def run(self, request: HttpRequest, **kw: Any) -> HttpResponseBase:
with self._prep_run(
request, temporal_response=temporal_response, **kw
) as ctx:
route_function = self._get_route_function()
if route_function:
route_function.run_permission_check(ctx)

error = self._run_checks(request)
if error:
return error

route_function = self._get_route_function()
if route_function:
route_function.run_permission_check(ctx)

values = self._get_values(request, kw, temporal_response)
ctx.kwargs.update(values)
result = self.view_func(request, **values)
Expand Down Expand Up @@ -325,14 +325,14 @@ async def run(self, request: HttpRequest, **kw: Any) -> HttpResponseBase: # typ
async with self._prep_run(
request, temporal_response=temporal_response, **kw
) as ctx:
route_function = self._get_route_function()
if route_function:
await route_function.async_run_check_permissions(ctx) # type: ignore[attr-defined]

error = await self._run_checks(request)
if error:
return error

route_function = self._get_route_function()
if route_function:
await route_function.async_run_check_permissions(ctx) # type: ignore[attr-defined]

values = await self._get_values(request, kw, temporal_response) # type: ignore
ctx.kwargs.update(values)
result = await self.view_func(request, **values)
Expand Down
Loading