Skip to content

ModelService: in update(), exclude_unset instead of exclude_none #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eadwinCode merged 1 commit into from
Aug 15, 2025
Merged

ModelService: in update(), exclude_unset instead of exclude_none #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ninja_extra/controllers/model/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ async def create_async(self, schema: PydanticModel, **kwargs: t.Any) -> t.Any:
return await sync_to_async(self.create, thread_sensitive=True)(schema, **kwargs)

def update(self, instance: Model, schema: PydanticModel, **kwargs: t.Any) -> t.Any:
data = schema.model_dump(exclude_none=True)
data = schema.model_dump(exclude_unset=True)
data.update(kwargs)
for attr, value in data.items():
setattr(instance, attr, value)
Expand Down
Loading