Support controller reuse across multiple NinjaExtraAPI instances#293
Open
jdiego wants to merge 6 commits intoeadwinCode:masterfrom
Open
Support controller reuse across multiple NinjaExtraAPI instances#293jdiego wants to merge 6 commits intoeadwinCode:masterfrom
NinjaExtraAPI instances#293jdiego wants to merge 6 commits intoeadwinCode:masterfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #293 +/- ##
==========================================
- Coverage 98.01% 97.87% -0.14%
==========================================
Files 68 67 -1
Lines 2770 2824 +54
==========================================
+ Hits 2715 2764 +49
- Misses 55 60 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
@jdiego Nice work here. Thanks. |
Contributor
Author
|
@eadwinCode done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #287
Updated
NinjaExtraAPI.register_controllersto handle per-API isolation:and a fresh APIController to avoid shared global state.
_registered_controllers(WeakSet) to guard against duplicate registration on the same API._controller_clones(dict) to cache per-API clones and prevent creating multiple subclasses for the same original controller.Enhanced tests:
auto_discover_controllersrespectsauto_import=False.(distinct routers, correct
self.apibinding).