Skip to content

Conversation

@overfelt
Copy link
Collaborator

Split out real values precabs and precabs_base into Kokkos 1D views and pre-calculate the values and pass these as constant scalar values for each level.

The hope is that the calculation of these values outside of the Kokkos::single will eventually make the Kokkos::single into a Kokkos::parallel.

Note there is still a small Kokkos::single that was not able to be parallelized into at Kokkos::parallel because of a recursion relation in the calculation of precabs and precabs_base.

Split out real values precabs and precabs_base into Kokkos 1D
views and pre-calculate the values and pass these as constant
scalar values for each level.

The hope is that the calculation of these values outside of the
Kokkos::single will eventually make the Kokkos::single into a
Kokkos::parallel.

Note there is still a small Kokkos::single that was not able to
be parallelized into at Kokkos::parallel because of a recursion
relation in the calculation of precabs and precabs_base.
@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

❌ Patch coverage is 94.78417% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.33%. Comparing base (34c4d5c) to head (70435bb).

Files with missing lines Patch % Lines
src/mam4xx/wet_dep.hpp 94.48% 28 Missing ⚠️
...osol_optics/data_transfer_state_q_qqwc_to_prog.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   93.43%   93.33%   -0.10%     
==========================================
  Files         303      303              
  Lines       25177    24619     -558     
  Branches     2766     2817      +51     
==========================================
- Hits        23523    22978     -545     
+ Misses       1654     1641      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant