-
Notifications
You must be signed in to change notification settings - Fork 10
Start rewrite of compute_q_tendencies to eliminate Kokkos::single. #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
overfelt
wants to merge
18
commits into
main
Choose a base branch
from
overfelt/Compute_Q_Tendencies_Restructure_Kokkos_Loops
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Start rewrite of compute_q_tendencies to eliminate Kokkos::single. #488
overfelt
wants to merge
18
commits into
main
from
overfelt/Compute_Q_Tendencies_Restructure_Kokkos_Loops
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split out real values precabs and precabs_base into Kokkos 1D views and pre-calculate the values and pass these as constant scalar values for each level. The hope is that the calculation of these values outside of the Kokkos::single will eventually make the Kokkos::single into a Kokkos::parallel. Note there is still a small Kokkos::single that was not able to be parallelized into at Kokkos::parallel because of a recursion relation in the calculation of precabs and precabs_base.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #488 +/- ##
==========================================
- Coverage 93.43% 93.33% -0.10%
==========================================
Files 303 303
Lines 25177 24619 -558
Branches 2766 2817 +51
==========================================
- Hits 23523 22978 -545
+ Misses 1654 1641 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out real values precabs and precabs_base into Kokkos 1D views and pre-calculate the values and pass these as constant scalar values for each level.
The hope is that the calculation of these values outside of the Kokkos::single will eventually make the Kokkos::single into a Kokkos::parallel.
Note there is still a small Kokkos::single that was not able to be parallelized into at Kokkos::parallel because of a recursion relation in the calculation of precabs and precabs_base.