- 
                Notifications
    
You must be signed in to change notification settings  - Fork 508
 
Add Datanoise PicoADK v2 (RP2350). #2413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            earlephilhower
  merged 24 commits into
  earlephilhower:master
from
DatanoiseTV:picoadk-v2
  
      
      
   
  Sep 24, 2024 
      
    
  
     Merged
                    Changes from 11 commits
      Commits
    
    
            Show all changes
          
          
            24 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      8ea8e5f
              
                Add Datanoise PicoADK v2 (RP2350).
              
              
                DatanoiseTV 57dd632
              
                Add pins for Serial 2 (uses ADC shared pins).
              
              
                DatanoiseTV 2faff80
              
                Update PicoADK v1 and v2 to 4MB Flash
              
              
                DatanoiseTV 31c3b2b
              
                Re-run makeboards.
              
              
                DatanoiseTV a93d553
              
                Merge branch 'master' into picoadk-v2
              
              
                earlephilhower 08c119c
              
                Add PSRAM menu for Datanoise PicoADK v2.
              
              
                DatanoiseTV e0e856e
              
                Merge branch 'picoadk-v2' of github.com:DatanoiseTV/arduino-pico into…
              
              
                DatanoiseTV bf3a598
              
                Merge branch 'master' into picoadk-v2
              
              
                earlephilhower 0fb2dab
              
                Update makeboards.py for PicoADK v2.
              
              
                DatanoiseTV 31e0aab
              
                Merge branch 'picoadk-v2' of github.com:DatanoiseTV/arduino-pico into…
              
              
                DatanoiseTV 6d637ce
              
                Update makeboards.py for PicoADK v2.
              
              
                DatanoiseTV 5f8dd00
              
                Update Build for PicoADK v2.
              
              
                DatanoiseTV d2855a8
              
                Update Build for PicoADK v2.
              
              
                DatanoiseTV 317d74d
              
                Merge branch 'master' into picoadk-v2
              
              
                DatanoiseTV b76b040
              
                Trying againg.
              
              
                DatanoiseTV f9af81b
              
                Merge branch 'picoadk-v2' of github.com:DatanoiseTV/arduino-pico into…
              
              
                DatanoiseTV bf15caa
              
                Set maximum PSRAM speed in variant, remove custom option menus.
              
              
                DatanoiseTV 2d0c3e8
              
                Update PicoADK v2 PSRAM CS.
              
              
                DatanoiseTV 65e6da3
              
                Merge branch 'master' into picoadk-v2
              
              
                DatanoiseTV 05f9f5d
              
                Change USB PID for Datanoise PicoADK v2 and fix double entries.
              
              
                DatanoiseTV 8932066
              
                Merge branch 'picoadk-v2' of github.com:DatanoiseTV/arduino-pico into…
              
              
                DatanoiseTV e92ffd5
              
                Change USB PID for Datanoise PicoADK v2 and fix double entries.
              
              
                DatanoiseTV 4bc3684
              
                Revert "Change USB PID for Datanoise PicoADK v2 and fix double entries."
              
              
                DatanoiseTV 45103bf
              
                Update README.md for Datanoise PicoADK versions.
              
              
                DatanoiseTV File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
      
      Oops, something went wrong.
      
    
  
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| { | ||
| "build": { | ||
| "arduino": { | ||
| "earlephilhower": { | ||
| "boot2_source": "boot2_w25q080_2_padded_checksum.S", | ||
| "usb_vid": "0x2E8A", | ||
| "usb_pid": "0x000A" | ||
| } | ||
| }, | ||
| "core": "earlephilhower", | ||
| "cpu": "cortex-m33", | ||
| "extra_flags": "-DARDUINO_DATANOISETV_PICOADK_V2 -DARDUINO_ARCH_RP2040 -DUSBD_MAX_POWER_MA=250 ", | ||
| "f_cpu": "150000000L", | ||
| "hwids": [ | ||
| [ | ||
| "0x2E8A", | ||
| "0x00C0" | ||
| ], | ||
| [ | ||
| "0x2E8A", | ||
| "0x000A" | ||
| ] | ||
| ], | ||
| "mcu": "rp2350", | ||
| "variant": "datanoisetv_picoadk_v2" | ||
| }, | ||
| "debug": { | ||
| "jlink_device": "RP2350_0", | ||
| "openocd_target": "rp2350.cfg", | ||
| "svd_path": "rp2350.svd" | ||
| }, | ||
| "frameworks": [ | ||
| "arduino" | ||
| ], | ||
| "name": "PicoADK v2", | ||
| "upload": { | ||
| "maximum_ram_size": 524288, | ||
| "maximum_size": 4194304, | ||
| "require_upload_port": true, | ||
| "native_usb": true, | ||
| "use_1200bps_touch": true, | ||
| "wait_for_upload_port": false, | ||
| "protocol": "picotool", | ||
| "protocols": [ | ||
| "blackmagic", | ||
| "cmsis-dap", | ||
| "jlink", | ||
| "raspberrypi-swd", | ||
| "picotool", | ||
| "picoprobe" | ||
| ] | ||
| }, | ||
| "url": "https://www.raspberrypi.org/products/raspberry-pi-pico/", | ||
| "vendor": "DatanoiseTV" | ||
| } | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| #pragma once | ||
| 
     | 
||
| // DatanoiseTV PicoADK v2 - Audio Development Kit with RP2350A | ||
| // https://github.com/DatanoiseTV/PicoDSP-Hardware | ||
| 
     | 
||
| // LEDs | ||
| #define PIN_LED (2u) | ||
| #define LED_BUILTIN PIN_LED | ||
| 
     | 
||
| // Serial - relocated | ||
| #define PIN_SERIAL1_TX (12u) | ||
| #define PIN_SERIAL1_RX (13u) | ||
| 
     | 
||
| // Serial 2 - relocated | ||
| #define PIN_SERIAL2_TX (27u) | ||
| #define PIN_SERIAL2_RX (28u) | ||
| 
     | 
||
| // SPI0 | ||
| #define PIN_SPI0_MISO (8u) | ||
| #define PIN_SPI0_MOSI (7u) | ||
| #define PIN_SPI0_SCK (6u) | ||
| #define PIN_SPI0_SS (5u) | ||
| 
     | 
||
| // SPI1 | ||
| #define PIN_SPI1_MISO (12u) | ||
| #define PIN_SPI1_MOSI (11u) | ||
| #define PIN_SPI1_SCK (10u) | ||
| #define PIN_SPI1_SS (13u) | ||
| 
     | 
||
| // Wire | ||
| #define PIN_WIRE0_SDA (8u) | ||
| #define PIN_WIRE0_SCL (9u) | ||
| 
     | 
||
| #define PIN_WIRE1_SDA (6u) | ||
| #define PIN_WIRE1_SCL (7u) | ||
| 
     | 
||
| // I2S | ||
| #define PIN_I2S_BCLK (17u) | ||
| #define PIN_I2S_LRCLK (18u) | ||
| #define PIN_I2S_DOUT (16u) | ||
| #define PIN_I2S_DIN (15u) | ||
| 
     | 
||
| #define SERIAL_HOWMANY (3u) | ||
| #define SPI_HOWMANY (2u) | ||
| #define WIRE_HOWMANY (2u) | ||
| 
     | 
||
| // PSRAM | ||
| #define RP2350_PSRAM_CS (0u) | ||
| #define PIN_PSRAM_CS RP2350_PSRAM_CS | ||
| 
     | 
||
| // SDIO for SD Card | ||
| #define PIN_SDIO_CLK (20u) | ||
| #define PIN_SDIO_CMD (21u) | ||
| #define PIN_SDIO_D0 (22u) | ||
| #define PIN_SDIO_D1 (23u) | ||
| #define PIN_SDIO_D2 (24u) | ||
| #define PIN_SDIO_D3 (25u) | ||
| 
     | 
||
| // MIDI | ||
| #define PIN_MIDI_RX (1u) | ||
| 
     | 
||
| #include "../generic/common.h" | 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BukldPSRAMCS,BuildPSRAMFREQ, andBuildFreqaren't needed here. You have a hard-wired board and know the CS pin (which should be a#define PSRAM_CS xxxinvariants/datanoisetv_v2/pins_arduino.h). There's no reason to have these as a menu. Only the first PSRAM size viabuildpsramis needed here. See thechallenger_2350_bconnector other RP2350 board w/PSRAM for more info...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I should just leave BuildPSRAM? Could you check the latest commit and maybe make necessary changes if possible? I am currently working on some example code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If your board always has PSRAM then there's no need for these menus. Define the proper pin/clock/CS in the variant.h like in the other 2350+PSRAM boards and it will "just work."
If there are 2 boards, 1 with and 1 without, then only the BuildPSRAM menu makes sense to have because everything else if defined by the PCB.
BuildFreqis called 3 lines below, so the instance here is duplicate That's not legal and I'm not sure what the IDE will do in that case. Best case you end up with some weird dup's menu items.